Fix run_filter failing tests
#158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hechth
approved these changes
Nov 8, 2022
|
@xtrojak it looks good to me !. |
wverastegui
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #156, we introduced a minor change that caused some tests for
unsupervisedandhybridto fail.The issue was identified in the refactored
run_filterfunctions, in particular in the call ofcompute_uniq_grp(L102), where the argumentmin_preswas not passed and the default value was always used.I also introduced more test cases for
run_filterfunction. The test files are introduced here.Since the issue was pretty minor, we don't need to revert the PR and close #157.