Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce usage of default argument values #168

Merged
merged 14 commits into from
Dec 6, 2022

Conversation

xtrojak
Copy link

@xtrojak xtrojak commented Dec 5, 2022

The default argument values were pretty messy and used in many top and low-level functions. In #162 we decided to keep them only on top-level unsupervised and hybrid functions and eliminate all the rest.

Part of #159 and #53.
Close #162.

@xtrojak xtrojak marked this pull request as ready for review December 5, 2022 13:47
@hechth
Copy link
Member

hechth commented Dec 6, 2022

@xtrojak the CI is failing since the code for the examples also relied on the default values

> ### ** Examples
> 
> data(prof)
> this.feature<-prof.to.features(prof[[1]])

So seems like we have to pass those values now in the examples.

@xtrojak
Copy link
Author

xtrojak commented Dec 6, 2022

@xtrojak the CI is failing since the code for the examples also relied on the default values

> ### ** Examples
> 
> data(prof)
> this.feature<-prof.to.features(prof[[1]])

So seems like we have to pass those values now in the examples.

Thank you, @hechth. Actually, I noticed there is bunch of outdated .Rd files that do not correspond to any functions. Some of them also contained examples. I removed them in e25c165.

@hechth
Copy link
Member

hechth commented Dec 6, 2022

@xtrojak with the CI taking so long maybe it is time to implement it a bit differently in the future.

R/compute_clusters.R Show resolved Hide resolved
R/find.tol.R Show resolved Hide resolved
@hechth hechth merged commit 671ba38 into RECETOX:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Where to supply default arguments
2 participants