-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce usage of default argument values #168
Conversation
@xtrojak the CI is failing since the code for the examples also relied on the default values
So seems like we have to pass those values now in the examples. |
Thank you, @hechth. Actually, I noticed there is bunch of outdated |
@xtrojak with the CI taking so long maybe it is time to implement it a bit differently in the future. |
The default argument values were pretty messy and used in many top and low-level functions. In #162 we decided to keep them only on top-level unsupervised and hybrid functions and eliminate all the rest.
Part of #159 and #53.
Close #162.