Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored, renamed variables, updated comments of rm.ridge.R #171

Merged
merged 10 commits into from
Jan 12, 2023
Merged

Refactored, renamed variables, updated comments of rm.ridge.R #171

merged 10 commits into from
Jan 12, 2023

Conversation

wverastegui
Copy link

hechth
hechth requested changes Dec 16, 2022
View reviewed changes
R/rm.ridge.R Outdated Show resolved Hide resolved
maximskorik
maximskorik reviewed Dec 21, 2022
View reviewed changes
R/rm.ridge.R Outdated Show resolved Hide resolved
maximskorik
maximskorik reviewed Dec 21, 2022
View reviewed changes
R/rm.ridge.R Outdated Show resolved Hide resolved
maximskorik
maximskorik approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@maximskorik maximskorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few suggestions for where improvements can be made. Otherwise looks good!

@hechth hechth merged commit aa11247 into RECETOX:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hechth hechth hechth approved these changes

@maximskorik maximskorik maximskorik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor rm.ridge function
3 participants
@wverastegui @hechth @maximskorik