Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full test data test for unsupervised and hybrid #177

Merged
merged 16 commits into from
Jan 26, 2023

Conversation

zargham-ahmad
Copy link

This PR includes the following:

closes #69 closes #58 closes #174 closes #175

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 65.63% // Head: 66.29% // Increases project coverage by +0.65% 🎉

Coverage data is based on head (8158221) compared to base (aa11247).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
+ Coverage   65.63%   66.29%   +0.65%     
==========================================
  Files          23       23              
  Lines        2590     2602      +12     
==========================================
+ Hits         1700     1725      +25     
+ Misses        890      877      -13     
Impacted Files Coverage Δ
R/compute_clusters.R 81.63% <100.00%> (+3.06%) ⬆️
R/hybrid.R 100.00% <100.00%> (ø)
R/recover.weaker.R 98.31% <100.00%> (+4.41%) ⬆️
R/unsupervised.R 99.28% <100.00%> (+0.01%) ⬆️
R/utils.R 88.88% <100.00%> (-0.16%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@maximskorik maximskorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'd only rename that skip variable so that if someone reads that code, they know what it's for without looking into the test implementation.

Copy link

@xtrojak xtrojak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good job, thank you for this @zargham-ahmad !

R/compute_clusters.R Outdated Show resolved Hide resolved
R/hybrid.R Show resolved Hide resolved
Copy link
Member

@hechth hechth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - do you agree @xtrojak ?

@zargham-ahmad could you only add the changes to the changelog?

@hechth hechth merged commit 3cff037 into RECETOX:master Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants