-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full test data test for unsupervised and hybrid #177
Conversation
Codecov ReportBase: 65.63% // Head: 66.29% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #177 +/- ##
==========================================
+ Coverage 65.63% 66.29% +0.65%
==========================================
Files 23 23
Lines 2590 2602 +12
==========================================
+ Hits 1700 1725 +25
+ Misses 890 877 -13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'd only rename that skip
variable so that if someone reads that code, they know what it's for without looking into the test implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good job, thank you for this @zargham-ahmad !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - do you agree @xtrojak ?
@zargham-ahmad could you only add the changes to the changelog?
This PR includes the following:
unsupervised
method #69hybrid
method #58closes #69 closes #58 closes #174 closes #175