Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored find.match function #193

Merged
merged 6 commits into from
Apr 15, 2023
Merged

Conversation

zargham-ahmad
Copy link

This PR contains the following:

  • extracted function, renamed variables, and updated some logic to make it more readable

closes #120

Copy link
Member

@hechth hechth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apply suggested comments, otherwise looks good.

R/find.match.R Outdated Show resolved Hide resolved
R/find.match.R Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 90.90% and project coverage change: +0.06 🎉

Comparison is base (12522b2) 66.61% compared to head (b3eae10) 66.67%.

❗ Current head b3eae10 differs from pull request most recent head 4fd428f. Consider uploading reports for the commit 4fd428f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   66.61%   66.67%   +0.06%     
==========================================
  Files          23       23              
  Lines        2627     2626       -1     
==========================================
+ Hits         1750     1751       +1     
+ Misses        877      875       -2     
Impacted Files Coverage Δ
R/semi.sup.R 0.00% <0.00%> (ø)
R/find.match.R 100.00% <100.00%> (+9.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hechth hechth merged commit e84061c into RECETOX:master Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor find.match.R
2 participants