-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented new version for clustering #201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job with the rewrite of clustering, looks awesome!
Co-authored-by: Matej Troják <trojak@mail.muni.cz>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@@ -0,0 +1,21 @@ | |||
test_that("compute_rt_tol_relative computes something", { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"computes something"?
@hechth Does deleting man files really make any difference in the repo size because they were around 80 kb anyways? Also, I think the CI seems to be failing because of it |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #201 +/- ##
==========================================
- Coverage 66.13% 65.84% -0.29%
==========================================
Files 23 23
Lines 2616 2685 +69
==========================================
+ Hits 1730 1768 +38
- Misses 886 917 +31
☔ View full report in Codecov by Sentry. |
Co-authored-by: Zargham Ahmad <46793118+zargham-ahmad@users.noreply.github.com>
Closes #198
Closes #199