-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor find.turn.point.R and find.tol.time.R and recover.weaker.R #91
Conversation
…able and renamed matching function
find.turn.pint.R was reverted to refactored version, Turnpoint function prevents passing the tests. Changelog file was updated accordingly (96c64ae) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider spending more time with the merge, I think the final version could benefit from both your and my refactored versions.
Thanks for the hint - I'll have a better look and see how to merge it better! Thanks for paying attention to details :) |
Co-authored-by: Matej Troják <trojak@mail.muni.cz>
Refactored find.tol.time.R and find.turn.point.R. The pastecs library has been added to use the Turnpoint function in find.turn.point.R, that simplifies the code. Added pastecs to dependencies.
Closes #90
Closes #77
This PR now also includes the changes from #92 to fix the overarching test cases, as fixing the things for this PR would require changes in other functions, so I decided to append all changes from #92 here.
Closes #74