Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use old behavior if formatting scope < indention #269

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Use old behavior if formatting scope < indention #269

merged 2 commits into from
Jun 2, 2020

Conversation

renkun-ken
Copy link
Member

@renkun-ken renkun-ken commented Jun 1, 2020 •
edited
Loading

As suggested at r-lib/styler#641 (comment), style$indention is checked so that #268 is only applied to scope >= "indention".

randy3k
randy3k approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@randy3k randy3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I didn't look into the apply_initial_indention function.

@renkun-ken renkun-ken merged commit 7cbf906 into REditorSupport:master Jun 2, 2020
@renkun-ken renkun-ken mentioned this pull request Jun 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randy3k randy3k randy3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@renkun-ken @randy3k