-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement renameProvider #339
Conversation
Sorry for the slow review. Will try to find some time to do it tomorrow. |
@randy3k Is there anything you think should be improved? |
LGTM. Sorry for missing it. |
By the way, how's its performance for a large project? |
renameProvider relies on referencesProivder which again relies on definitionProvider. The performance of renameProvider is almost equal to that of the referencesProvider. I tried using the |
That's what I was referring to. But anyway, such of use case should not be common. |
👍 👍 Thank you for this feature |
Great feature, thanks a lot! 👍 |
Close #337
This PR implements prepareRename and renameProvider based on the referenceProvider implemented by #338 by transforming the references into a WorkspaceEdit.