Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking symbol on rhs of assignment expression #342

Merged
merged 2 commits into from
Oct 2, 2020

Conversation

renkun-ken
Copy link
Member

Close #341

This PR improves the XPaths of definition and hover so that the XPaths ensure that the requested token is not included in the value expression of the assignment, i.e. RHS of left assignment and equal assignment and LHS of right assignment.

Then the definition and hover providers will regard line 1 as the definition of token test in line 2 on RHS of the assignment:

test <- 1
test <- test + 1

@renkun-ken renkun-ken requested a review from randy3k September 22, 2020 23:49
Copy link
Member

@randy3k randy3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Actually, the XPATH syntax is too complex for me to review 😓

@renkun-ken renkun-ken merged commit be13407 into REditorSupport:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check if symbol on rhs of assignment in definition
2 participants