Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hover on function defined with EQ_ASSIGN #467

Merged
merged 3 commits into from
Aug 11, 2021

Conversation

renkun-ken
Copy link
Member

Closes #466

This PR fixes the XPath to extract function signature from the definition with EQ_ASSIGN by matching expr/LEFT_ASSIGN and expr_or_assign_or_help/EQ_ASSIGN in the XML parse tree.

@renkun-ken renkun-ken requested a review from randy3k August 11, 2021 03:11
@randy3k
Copy link
Member

randy3k commented Aug 11, 2021

LGTM. You have became an expert of xpath 😄.

@renkun-ken renkun-ken merged commit 2a8ac66 into REditorSupport:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for functions assigned with = differs from functions assigned with <-
2 participants