Enable the folding of binary operations #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this! Would you like to add some test cases to |
|
This is okay. One uncertain thing: Do you think it's necessary to fold |
|
Thanks for the test cases. As for |
renkun-ken
reviewed
Apr 23, 2023
| "\\?" | ||
| ) | ||
| binary_opts_regex <- paste0(binary_opts, collapse = "|") | ||
| binary_opts_ending_regex <- paste0("^[^#]*(", binary_opts_regex, ")\\s*(#.*)?$") |
There was a problem hiding this comment.
Just did a small refactoring here to put the regex pre-computed. It is also useful to fix #607 in on-type-formatting. I'll probably put these into utils.R in a later PR so that both folding and on-type-formatting could share this.
|
Everything is fine, thanks for the code reviewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for my bad coding style which may prevent the understanding, In this commit I also tried to add more notes comment.
But the main purpose is to fix REditorSupport/vscode-R#1076
Binary operations are collapsed
