Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Httpgd plot viewer not working with LiveShare #1023

Closed
renkun-ken opened this issue Mar 3, 2022 · 9 comments · Fixed by #1026
Closed

Httpgd plot viewer not working with LiveShare #1023

renkun-ken opened this issue Mar 3, 2022 · 9 comments · Fixed by #1026
Labels

Comments

@renkun-ken
Copy link
Member

Currently, httpgd plot viewer does not seems to work with LiveShare. Not sure if it is possible to support this.

@renkun-ken renkun-ken added the bug label Mar 3, 2022
@nx10
Copy link
Contributor

nx10 commented Mar 3, 2022

I would be happy to implement what is needed server-side to support this.

@renkun-ken
Copy link
Member Author

@ElianHugh do you think if there is a handy way to forward a httpgd plot to the client session?

@ElianHugh
Copy link
Collaborator

Hmm, this was definitely working before. It may be there was a regression at some point. I'll have a look to see where the issue is

@renkun-ken
Copy link
Member Author

httpgd::hgd_browse() that creates a WebView works with LiveShare.

I tried rolling back to previous versions but the built-in httpgd plot viewer never worked.

@renkun-ken
Copy link
Member Author

However, if I start debugging and join a LiveShare session, then the httpgd plot viewer works.

@renkun-ken
Copy link
Member Author

Looks like all features that depend on a http server on localhost do not work as we don't have a mechanism of port forwarding from host to guest, then visiting the URL by httpgd plot viewer and all browser requests simply get nothing.

@renkun-ken
Copy link
Member Author

When I manually use "Share Server" to share the localhost url, then the viewer works as supposed.

@renkun-ken
Copy link
Member Author

Just notice that I didn't enable "Auto forward ports. Now just httpgd does not work as we don't share port before notifying guest the httpgd request.

@ElianHugh
Copy link
Collaborator

Thanks for digging into that. I suspect we didn't run into this issue because of it working during debugging. As an aside, "auto forward ports" was (from memory) untoggled due to security concerns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants