-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Httpgd plot viewer not working with LiveShare #1023
Comments
I would be happy to implement what is needed server-side to support this. |
@ElianHugh do you think if there is a handy way to forward a httpgd plot to the client session? |
Hmm, this was definitely working before. It may be there was a regression at some point. I'll have a look to see where the issue is |
I tried rolling back to previous versions but the built-in httpgd plot viewer never worked. |
However, if I start debugging and join a LiveShare session, then the httpgd plot viewer works. |
Looks like all features that depend on a http server on localhost do not work as we don't have a mechanism of port forwarding from host to guest, then visiting the URL by httpgd plot viewer and all browser requests simply get nothing. |
When I manually use "Share Server" to share the localhost url, then the viewer works as supposed. |
Just notice that I didn't enable "Auto forward ports. Now just httpgd does not work as we don't share port before notifying guest the httpgd request. |
Thanks for digging into that. I suspect we didn't run into this issue because of it working during debugging. As an aside, "auto forward ports" was (from memory) untoggled due to security concerns |
Currently, httpgd plot viewer does not seems to work with LiveShare. Not sure if it is possible to support this.
The text was updated successfully, but these errors were encountered: