Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share httpgd url for LiveShare #1026

Merged
merged 7 commits into from
Mar 5, 2022

Conversation

renkun-ken
Copy link
Member

@renkun-ken renkun-ken commented Mar 4, 2022

What problem did you solve?

Closes #1023

When a new httpgd viewer is created, the httpgd url is shared if auto forward ports is enabled.

I tested on a Windows host and a Ubuntu client, it works as expected.

(If you do not have screenshot) How can I check this pull request?

  1. Start live share session on host
  2. join live share session on a client on separate server
  3. Enable auto forward ports, use httpgd
  4. Create an R session
  5. plot(1).
  6. An item of httpgd (127.0.0.1:port) will show up in the shared servers of live share side view.
  7. Both host and client will open the httpgd plot viewer and the plot could be properly displayed.

@renkun-ken renkun-ken merged commit e290901 into REditorSupport:master Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Httpgd plot viewer not working with LiveShare
1 participant