-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ag-grid in data viewer #708
Conversation
Looking great! By any chance "Pagination" means dynamic loading? It would be perfect. |
It's not dynamic loading here. |
Is there another setup requirement in addition to running (Error: Unable to resolve non-existing file 'vscode-remote://wsl+ubuntu-20.04/vscode-resource?{"requestResourcePath":"/home/elian/coding/VS/vscode-R/dist/resources/ag-grid-community.min.noStyle.js"}') |
We need those js css resources to be copied from |
Looks great! Would you like to provide a better css here? |
- May necessitate a .css file?
I've done some changes to make it also work with high-contrast theme. Now everything looks good. |
Looks good and works well, thanks! |
What problem did you solve?
Closes #506
This PR replaces DataTables with ag-grid in the data viewer.
(If you have)Screenshot
Kapture.2021-07-15.at.23.03.56.mp4
(If you do not have screenshot) How can I check this pull request?
View any data.frame or matrix and the data viewer will use
ag-grid
to present the table with the following features: