Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed "punctuation.section.parens.end.r" under "function-parameters" #931

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Conversation

RedCMD
Copy link
Contributor

@RedCMD RedCMD commented Jan 4, 2022

What problem did you solve?

Fixed end bracket not being tokenized "punctuation.section.parens.end.r" under "function-parameters" because "name" was not used

Happened to see it while looking through random vscode extensions
(in red at the bottom)
image

Happened to see it while looking through random vscode extensions
@renkun-ken
Copy link
Member

Thanks for the fix!

Would you like to provide an example code that demonstrates the problem?

@RedCMD
Copy link
Contributor Author

RedCMD commented Jan 4, 2022

On closer inspection, it seems that, that part of the highlighter code does nothing
and should just be removed entirely
'Remove absolute "end" pattern under "function-parameters"'

@renkun-ken
Copy link
Member

Would you like to show the incorrect syntax highlighting before this fix?

@RedCMD
Copy link
Contributor Author

RedCMD commented Jan 6, 2022

A R code example?
there would be none because the code never tries to match anything
its just dead code
most likely left over from some testing
because the "end" rule has no "begin" rule, it is never evaluated during runtime and thus does nothing
(Sorry I didn't notice this at first)
The code in question was added here on line 333/467 743737a#diff-f6f05bbc187255f5cf06a39e3a4f7befa7288489c5fd44bb14586143076ffd1d

Copy link
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renkun-ken renkun-ken merged commit 0f59ed2 into REditorSupport:master Jan 11, 2022
@RedCMD RedCMD deleted the patch-1 branch January 11, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants