Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commented pipe bug #988

Merged
merged 2 commits into from
Feb 12, 2022
Merged

Conversation

gowerc
Copy link
Contributor

@gowerc gowerc commented Feb 12, 2022

What problem did you solve?

Resolved the mixed quote issue bug here: #987
Renamed unit test file to better represent what they are testing.
Added new unit tests for cleanlines

(If you have)Screenshot

Before:
image

After:
image

@gowerc gowerc changed the title Selection tests Fix commented pipe bug Feb 12, 2022
Copy link
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

LGTM

@renkun-ken renkun-ken merged commit 5f7b9e8 into REditorSupport:master Feb 12, 2022
@gowerc gowerc deleted the selection-tests branch September 6, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants