Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong syntax in SIGNALduino_Parse_MS & SIGNALduino_Parse_MC #1049

Merged
merged 3 commits into from
Dec 17, 2021

Conversation

HomeAutoUser
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)

examples:

2021.12.16 18:56:16.920 3: sduino_radino_433Mhz: Parse_MS, faulty rssi R=: xyz
2021.12.16 18:56:16.923 1: PERL WARNING: Use of uninitialized value $rssiStr in concatenation (.) or string at ./FHEM/00_SIGNALduino.pm line 2498.
2021.12.16 18:56:16.924 1: stacktrace:
2021.12.16 18:56:16.924 1:     main::__ANON__                      called by ./FHEM/00_SIGNALduino.pm (2498)
2021.12.16 18:56:16.924 1:     main::SIGNALduino_Parse_MS          called by ./FHEM/00_SIGNALduino.pm (2980)
2021.12.16 18:56:16.924 1:     main::SIGNALduino_Parse             called by ./FHEM/00_SIGNALduino.pm (1820)
2021.12.16 18:56:16.924 1:     main::SIGNALduino_Read              called by fhem.pl (3895)
2021.12.16 18:56:16.924 1:     main::CallFn                        called by fhem.pl (773)

--------------------------------------------------------------------------------------------------------------

2021.12.16 19:12:10.139 3: sduino_nano_433Mhz: Parse_MC, faulty clock: asd;
2021.12.16 19:12:10.140 1: PERL WARNING: Use of uninitialized value $clock in numeric gt (>) at ./FHEM/00_SIGNALduino.pm line 2812.
2021.12.16 19:12:10.140 1: stacktrace:
2021.12.16 19:12:10.140 1:     main::__ANON__                      called by ./FHEM/00_SIGNALduino.pm (2812)
2021.12.16 19:12:10.140 1:     main::SIGNALduino_Parse_MC          called by ./FHEM/00_SIGNALduino.pm (2989)
2021.12.16 19:12:10.140 1:     main::SIGNALduino_Parse             called by ./FHEM/00_SIGNALduino.pm (1820)
2021.12.16 19:12:10.141 1:     main::SIGNALduino_Read              called by fhem.pl (3895)
2021.12.16 19:12:10.141 1:     main::CallFn                        called by fhem.pl (773)

--------------------------------------------------------------------------------------------------------------

2021.12.16 19:15:02.396 3: sduino_nano_433Mhz: Parse_MC, faulty mcbitnum: bit;
2021.12.16 19:15:02.397 1: PERL WARNING: Use of uninitialized value $mcbitnum in numeric gt (>) at ./FHEM/00_SIGNALduino.pm line 2839.
2021.12.16 19:15:02.397 1: stacktrace:
2021.12.16 19:15:02.397 1:     main::__ANON__                      called by ./FHEM/00_SIGNALduino.pm (2839)
2021.12.16 19:15:02.397 1:     main::SIGNALduino_Parse_MC          called by ./FHEM/00_SIGNALduino.pm (2989)
2021.12.16 19:15:02.397 1:     main::SIGNALduino_Parse             called by ./FHEM/00_SIGNALduino.pm (1820)
2021.12.16 19:15:02.397 1:     main::SIGNALduino_Read              called by fhem.pl (3895)
2021.12.16 19:15:02.397 1:     main::CallFn                        called by fhem.pl (773)

--------------------------------------------------------------------------------------------------------------

2021.12.16 19:17:26.419 3: sduino_nano_433Mhz: Parse_MC, faulty rawData D=: esel
2021.12.16 19:17:26.419 1: PERL WARNING: Use of uninitialized value $hlen in multiplication (*) at ./FHEM/00_SIGNALduino.pm line 2801.
2021.12.16 19:17:26.419 1: stacktrace:
2021.12.16 19:17:26.419 1:     main::__ANON__                      called by ./FHEM/00_SIGNALduino.pm (2801)
2021.12.16 19:17:26.419 1:     main::SIGNALduino_Parse_MC          called by ./FHEM/00_SIGNALduino.pm (2989)
2021.12.16 19:17:26.419 1:     main::SIGNALduino_Parse             called by ./FHEM/00_SIGNALduino.pm (1820)
2021.12.16 19:17:26.420 1:     main::SIGNALduino_Read              called by fhem.pl (3895)
2021.12.16 19:17:26.420 1:     main::CallFn                        called by fhem.pl (773)

  • What is the new behavior (if this is a feature change)?

    • no error´s and code give return
      --> fault has been corrected
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

    • write error in the code (probably confused with bash)

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #1049 (60cedce) into master (5316b5d) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1049      +/-   ##
==========================================
- Coverage   61.58%   61.35%   -0.24%     
==========================================
  Files         127      126       -1     
  Lines        9353     9328      -25     
  Branches     1479     1476       -3     
==========================================
- Hits         5760     5723      -37     
- Misses       2519     2534      +15     
+ Partials     1074     1071       -3     
Flag Coverage Δ
fhem 52.61% <100.00%> (-0.24%) ⬇️
modules 61.35% <100.00%> (-0.24%) ⬇️
perl 91.61% <ø> (-0.22%) ⬇️
unittests 61.35% <100.00%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/00_SIGNALduino.pm 63.17% <100.00%> (-0.65%) ⬇️
FHEM/lib/SD_Protocols.pm 79.17% <0.00%> (-0.58%) ⬇️
t/FHEM/14_SD_AS/00_load.t
t/FHEM/14_SD_UT/09_parseDatat.t
t/FHEM/14_BresserTemeo/00_load.t 100.00% <0.00%> (ø)
FHEM/10_SD_Rojaflex.pm 71.54% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5316b5d...60cedce. Read the comment docs.

@HomeAutoUser HomeAutoUser merged commit a685fc2 into master Dec 17, 2021
@HomeAutoUser HomeAutoUser deleted the master_Syntax_Parse_MC_MS branch December 17, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants