Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gha-find-replace v3 #1277

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Use gha-find-replace v3 #1277

merged 2 commits into from
Oct 13, 2024

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Oct 13, 2024

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bugfix (please link issue)
  • Feature enhancement
  • Documentation update
  • Unittest enhancement
  • other
  • What is the current behavior?
    (You can also link to an open issue here, if this describes the current behavior)

Unable to resolve action jacobtomlinson/gha-find-replace@v3.0.4, unable to find version v3.0.4

  • What is the new behavior (if this is a feature change)?

Using a release tag v3 which has a tag with the same name v3

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

no

  • Other information:

@sidey79 sidey79 changed the title fix{version.yml]: Use gha-find-replace v3 which is also a valid tag Use gha-find-replace v3 Oct 13, 2024
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.16%. Comparing base (f4bcba1) to head (884f3bd).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1277      +/-   ##
==========================================
+ Coverage   84.62%   86.16%   +1.53%     
==========================================
  Files         137      139       +2     
  Lines       10226    10236      +10     
  Branches     1676     1676              
==========================================
+ Hits         8654     8820     +166     
+ Misses       1571     1415     -156     
  Partials        1        1              
Flag Coverage Δ
fhem 78.44% <ø> (+1.78%) ⬆️
modules 86.16% <ø> (+1.53%) ⬆️
perl 95.49% <ø> (+0.24%) ⬆️
unittests 86.16% <ø> (+1.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sidey79 sidey79 requested a review from elektron-bbs October 13, 2024 15:40
Copy link
Contributor

@elektron-bbs elektron-bbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich habe zwar keine Ahnung, wozu das gut ist, aber ich bestätige das mal :-)

@sidey79 sidey79 merged commit 8bdecbc into master Oct 13, 2024
16 checks passed
@sidey79 sidey79 deleted the fix-ghafindandreplace branch October 13, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants