Update signalduino_protocols.pm #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HomeAutoUser
commented
Feb 26, 2019
•
HomeAutoUser
commented
- Please check if the PR fulfills these requirements
- Tests for the changes have been added / modified (needed for for bug fixes / features)
- commandref has been added / updated (needed for bug fixes / features)
- CHANGED has been updated (needed for bug fixes / features)
- What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
- ID59 remove modulmatch (fix dispatch)
- ID87 + ID91 +91.1 added reconstructBit
- ID 73 remove developId => 'y',
- What is the current behavior? (You can also link to an open issue here)
- ID 59 is no dispatch witch modulmatch ""
- ID87 + ID91 +91.1 need reconstructBit
- ID 73 developId => 'y' is no development
- ID59 remove modulmatch (fix dispatch) - ID87 + ID91 +91.1 added reconstructBit - ID 73 remove developId => 'y',
|
Prinzipiell okay. Ich hatte reconstruct extra auskommentiert, da ich das Feature (generell) von den Protokollen getrennt sehe :) Für die Protokolle, bei denen es aktiviert wird, wäre ein Eintrag in Changed noch gut finde ich. |
- changed text
|
Soeben habe ich es in die CHANGED aufgenommen :-) |
sidey79
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.