Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify SD_WS07 Autocreate via unittest #536

Merged
merged 4 commits into from
Mar 5, 2019
Merged

Verify SD_WS07 Autocreate via unittest #536

merged 4 commits into from
Mar 5, 2019

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Mar 4, 2019

Added some basic tets for SD_WS07 Module, checks autocreate and pre defined
Added Test which checks for bug #527

This test must be added to #531 to verify if the PR is complete

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This PR adds some tests to verify the bug in #527 and check PR #531

  • What is the current behavior? (You can also link to an open issue here)

There are no tests for SD_WS07 module

  • What is the new behavior (if this is a feature change)?

There are some basic Tests for SD_WS07 Module

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

  • Other information:

I had to work with sleep between dispatches. That is not very nice but i currently have no other idea.

Output of test_SDWS07:
# Subtest: Check autocreate SD_WS07_TH_1
    1..3
    ok 1 - check sensor not created with single dispatch
    ok 2 - check sensor created with second dispatch
    ok 3 - check sensor deleted correctly
ok 100 - Check autocreate SD_WS07_TH_1
# Subtest: Check Dispatch() with existing definition only channel SD_WS07_TH_1
    1..4
    ok 1 - check sensor deleted correctly
    ok 2 - check sensor not created with single dispatch
    ok 3 - Check if definition is found by dispatch()
    ok 4 - check sensor deleted correctly
ok 101 - Check Dispatch() with existing definition only channel SD_WS07_TH_1
# Subtest: Check Dispatch() with existing definition model_channel SD_WS07_TH_1
    1..4
    ok 1 - check sensor deleted correctly
    ok 2 - check sensor not created with single dispatch
    not ok 3 - Check if definition is found by dispatch() # TODO This bug must be fixed
    ok 4 - check sensor deleted correctly
ok 102 - Check Dispatch() with existing definition model_channel SD_WS07_TH_1
# Subtest: Check autocreate with longid SD_WS07_TH_631
    1..4
    ok 1 - check sensor not created with single dispatch
    ok 2 - check sensor created with second dispatch
    ok 3 - Check if definition is found by dispatch()
    ok 4 - check sensor deleted correctly
ok 103 - Check autocreate with longid SD_WS07_TH_631

Added some basic tets for SD_WS07 Module, checks autocreate and pre defined
Added Test which checks for bug #527

This test must be added to #531 to verify if the PR is complete
@sidey79 sidey79 changed the title test/test_SDWS07-definition.txt Verify SD_WS07 Autocreate via unittest Mar 4, 2019
@sidey79 sidey79 added this to the 3.4 milestone Mar 4, 2019
Travis CI and others added 2 commits March 4, 2019 22:09
@sidey79 sidey79 marked this pull request as ready for review March 4, 2019 22:16
@sidey79 sidey79 requested a review from elektron-bbs March 4, 2019 22:16
@sidey79
Copy link
Contributor Author

sidey79 commented Mar 4, 2019

Ich habe ein Test als fehlerhaft akzeptiert, da er den aktuellen Bug belegt

not ok 3 - Check if definition is found by dispatch() # TODO This bug must be fixed

Dieser Test sollte mit deinem PR #531 behoben sein. Allerdings glaube ich, dass dafür ein anderer Test in einen Fehler läuft.

Ich kann den Test jetzt nicht so einfach in deinen Branch packen. Am besten wir mergen hier mit dev-r34 und updaten dann deinen elektron-bbs:dev-r34-SD_WS07 Branch mit dev-r34

@sidey79 sidey79 merged commit 82211b7 into dev-r34 Mar 5, 2019
@sidey79 sidey79 deleted the dev-r34-test527 branch March 5, 2019 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants