Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal versionProtocols fixed #542

Merged
merged 5 commits into from
Mar 8, 2019
Merged

internal versionProtocols fixed #542

merged 5 commits into from
Mar 8, 2019

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Mar 7, 2019 •
edited
Loading

Fixed internal versionProtocols

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? BugFix

Fixes the internal versionProtocols

  • What is the current behavior? (You can also link to an open issue here)

No value is shown in this internal

  • What is the new behavior (if this is a feature change)?

value from ProtocolData Package is displayed

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

no

  • Other information:
    image

@sidey79
00_SIGNALduino.pm
e6c96e6 
Fixed internal versionProtocols
@sidey79 sidey79 changed the title 00_SIGNALduino.pm internal versionProtocols fixed Mar 7, 2019
@sidey79 sidey79 marked this pull request as ready for review March 7, 2019 23:29
@sidey79 sidey79 requested a review from HomeAutoUser March 7, 2019 23:34
@sidey79
00_SIGNALduino.pm
9ea0b56 
update versionmodule
@sidey79 sidey79 added the bug label Mar 7, 2019
@sidey79 sidey79 merged commit b3ba7e2 into dev-r34 Mar 8, 2019
@sidey79 sidey79 deleted the patch-versionProtocols branch March 8, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HomeAutoUser HomeAutoUser HomeAutoUser approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sidey79 @HomeAutoUser