SD_WS_51 fix bug in longId #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correct longid from 12 to 8 bit, valid channels only 1-3
|
Funktionieren die bislang angelegten Sensoren denn noch nach diesem PR! |
|
Davon gehe ich aus. LongIds hat bisher offensichtlich noch niemand verwendet, sonst wäre der Fehler wohl eher aufgefallen. Ich habe hier Daten aus drei Issues ausgewertet und bei allen tritt der Fehler wie in dem verlinkten Issue auf. |
sidey79
approved these changes
Apr 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fix bug in longId from using 12 bit to 8 bit
check valid channels only 1-3
What is the current behavior? (You can also link to an open issue here)
Protokoll für Lidl T/H-Sensor IAN 60107 / Z32171D-TX #161 (comment)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Other information: