Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New protocol for Techmar Garden Lights #562

Merged
merged 4 commits into from
Apr 14, 2019
Merged

New protocol for Techmar Garden Lights #562

merged 4 commits into from
Apr 14, 2019

Conversation

elektron-bbs
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    SD_ProtocolData.pm: set protocol 94 to development
    README.md: new entries for Tedsen, Geiger and Techmar

  • What is the current behavior? (You can also link to an open issue here)
    Protokoll für Techmar / Garden Lights Fernbedienung #558

  • What is the new behavior (if this is a feature change)?
    14_SD_UT.pm: new protocol for Techmar Garden Lights
    SD_ProtocolData.pm: new definition protocol 95

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

14_SD_UT.pm: new protocol for Techmar Garden Lights
SD_ProtocolData.pm: set protocol 94 to development
SD_ProtocolData.pm: new definition protocol 95
README.md: new entries for Tedsen, Geiger and Techmar
@elektron-bbs elektron-bbs changed the title 14_SD_UT.pm: new protocol for Techmar Garden Lights New protocol for Techmar Garden Lights Apr 13, 2019
@coveralls
Copy link

coveralls commented Apr 13, 2019

Pull Request Test Coverage Report for Build 1417

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 1416: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1417

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 1416: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

@elektron-bbs elektron-bbs requested a review from sidey79 April 13, 2019 15:55
Copy link
Contributor

@sidey79 sidey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich habe mich gerade mal grundsätzlich gefragt, ob das Modul mit longids zurecht kommt.

@HomeAutoUser
Copy link
Contributor

Ich habe mich gerade mal grundsätzlich gefragt, ob das Modul mit longids zurecht kommt.

Wie meinst du dies? Wir haben es doch hier prinzipiell mit "festen" Id´s zu tun. Kann soeben nicht so richtig darauf antworten ;-)

@sidey79
Copy link
Contributor

sidey79 commented Apr 14, 2019

achso, ja wenn die IDs immer fest sind, dann braucht man sich die Frage nach Zufallscode ja nicht stellen.
Ich bin am überlegen ob wir nicht gleich mal einen Test erstellen sollten.

@elektron-bbs
Copy link
Contributor Author

Im Prinzip wird ja eigentlich immer eine Art "longId" verwendet. Bisher ist uns noch kein Device bekannt, das so etwas wie einen Kanal bei Wettersensoren verwendet.

@elektron-bbs elektron-bbs merged commit d27260e into RFD-FHEM:dev-r34 Apr 14, 2019
@sidey79
Copy link
Contributor

sidey79 commented Apr 15, 2019

Was war das jetzt mit dem Test? Überlesen oder brauchen wir den nicht?

@elektron-bbs
Copy link
Contributor Author

Für die Test's bist du zuständig :-)
Ich habe mich, ehrlich gesagt, damit noch nicht beschäftigt. Ich teste hier immer ausführlich auf meinen Systemen und erst, wenn ich mir sicher bin, das es funktioniert, wird es veröffentlicht.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants