Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Perl if needed to test whith most used versions #622

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Aug 5, 2019

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix with feature

  • What is the current behavior? (You can also link to an open issue here)

Perl 5.18 is not any longer available in a precompiled version from travis ci.
Tests are currently failing because of this

  • What is the new behavior (if this is a feature change)?

To prevent errors when travis removes support for a perl version, a perl helper (https://github.com/travis-perl/helpers) is used to use a precompiled version or compile a version if needed.
The used perl versions for testing are aligned to the most used from fhem statisics which are 5.26, 5.24, 5.20 and 5.14.

5.14 tests hangs but is allowed to fail.
If this issue can't be fixed i'll remove it from supported version.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:
    This PR just changed the way, how perl is installed for the unittests

@sidey79 sidey79 added bug priority priority, for better classification of the processing labels Aug 5, 2019
@sidey79 sidey79 mentioned this pull request Aug 5, 2019
3 tasks
download and run travis perl helper (github.com/travis-perl/helpers) to allow build of any perl version
try to build perl (and nothing more) which shoud be used for test
added cache to speed up test time
added most used perl versions by FHEM
try to use predefined coveralls modules if possible
allow failure of 5.14 because it seems to hang
@sidey79 sidey79 force-pushed the dev-r34_buildperl branch from 01356fc to 36e4786 Compare August 5, 2019 23:56
@sidey79 sidey79 merged commit 08c1092 into dev-r34 Aug 6, 2019
@sidey79 sidey79 deleted the dev-r34_buildperl branch October 28, 2019 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug priority priority, for better classification of the processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants