Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

00_SIGNALduino.pm - fix #636

Merged
merged 1 commit into from
Aug 30, 2019
Merged

00_SIGNALduino.pm - fix #636

merged 1 commit into from
Aug 30, 2019

Conversation

HomeAutoUser
Copy link
Contributor

@HomeAutoUser HomeAutoUser commented Aug 30, 2019 •
edited
Loading

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? Bug fix
  • What is the current behavior? (You can also link to an open issue here)
  • all browser or tabs refresh
  • What is the new behavior (if this is a feature change)?
  • browser windows showing other definitions are not refreshed anymore
  • browser windows showing the same definition are refreshed

@HomeAutoUser
00_SIGNALduino.pm - fix
4c3fdc7 
- fix browser refresh
RFD-FHEM#633
- tested with browser firefox & edge
@sidey79
Copy link
Contributor

sidey79 commented Aug 30, 2019

Ich habe es mir angesehen. Hätte gedacht der Filter muss mit dem Typ angegeben werden FILTER=NAME=$name wie bei devspec.
Dem ist hier aber nicht so.

Ich will jetzt nicht den Klugscheisser machen, aber der Zustand stimmt nicht:

  • only the one activ tab / windows refresh

Nur damit wir alle das gleiche Verständnis haben:

  • browser windows showing the same definition are refreshed
  • browser windows showing other definitions are not refreshed anymore

@HomeAutoUser
Copy link
Contributor Author

Soll ich nun die Beschreibung ändern? (Post 1)

@HomeAutoUser HomeAutoUser requested a review from sidey79 August 30, 2019 20:17
@sidey79
Copy link
Contributor

sidey79 commented Aug 30, 2019

Noe, wollte nur sichergehen, dass wir das gleiche Verständnis haben oder siehst Du es anders?

@HomeAutoUser
Copy link
Contributor Author

Alles gut, wir haben das gleiche Verständnis.

Ich habe es mir angesehen. Hätte gedacht der Filter muss mit dem Typ angegeben werden FILTER=NAME=$name wie bei devspec.
Dem ist hier aber nicht so.

Das ist leider zu wenig dokumentiert. Erst ein "Eingriff in die orginale Java Funktion" brachte den Aufschluss und somit die Lösung des Rätsels.

@HomeAutoUser HomeAutoUser merged commit 8b551a6 into RFD-FHEM:dev-r34 Aug 30, 2019
@HomeAutoUser HomeAutoUser deleted the dev_r34_fix_refresh branch August 30, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidey79 sidey79 sidey79 approved these changes

Assignees
No one assigned
Labels
bug fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HomeAutoUser @sidey79