14_SD_Keeloq.pm - fixes #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HomeAutoUser
commented
Sep 1, 2019
•
HomeAutoUser
commented
- Please check if the PR fulfills these requirements
- Tests for the changes have been added / modified (needed for for bug fixes / features)
- commandref has been added / updated (needed for bug fixes / features)
- CHANGED has been updated (needed for bug fixes / features)
- What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
- fix, feature
- What is the current behavior? (You can also link to an open issue here)
- shade function not work
- superfluous readings are always retained
- What is the new behavior (if this is a feature change)?
- added more information to JaroLift buttons
- fix Call SD_Keeloq_binsplit_JaroLift only if verbose >=5 #640 Call SD_Keeloq_binsplit_JaroLift only if verbose >=5
- fix shade function Shade ohne Funktion fhem/SD_Keeloq#9
- deleting superfluous readings when channels are being downsized ChannelAttribute Check fhem/SD_Keeloq#17
- added more information to JaroLift buttons - fix RFD-FHEM#640 Call SD_Keeloq_binsplit_JaroLift only if verbose >=5 - fix shade function fhem/SD_Keeloq#9
sidey79
reviewed
Sep 1, 2019
FHEM/14_SD_Keeloq.pm
Outdated
| my $Channels = AttrVal($name, "Channels", ""); | ||
| return "ERROR: you can use Channels = $attrValue only with defined attribut addGroups!" if ($attrValue == 0 && $addGroups eq ""); | ||
| if ($Channels > $attrValue) { | ||
| foreach my $d (sort keys %{$hash->{READINGS}}) { |
There was a problem hiding this comment.
Ist das sortieren notwendig?
There was a problem hiding this comment.
In der Sache nicht unbedingt. Es wäre ein klassischer Copy&Paste wie dies da hinkam :-)
Würde das zusätzliche sort so viel ausmachen an Ressourcen? Ja es wäre unötige aber rein informell mal.
There was a problem hiding this comment.
Es verbraucht halt CPU Ressourcen weil die komplette Liste sortiert wird.
Wenn man es nicht braucht, sollte man es weglassen
There was a problem hiding this comment.
Es ist doch schon geschehen :-) Somit ist nur das benötigte im Code.
- remove unnecessary sort function RFD-FHEM#643 (review)
sidey79
previously approved these changes
Sep 1, 2019
Pull Request Test Coverage Report for Build 1721
💛 - Coveralls |
sidey79
approved these changes
Sep 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.