Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unitetests for get raw #650

Merged
merged 3 commits into from
Sep 13, 2019
Merged

Add unitetests for get raw #650

merged 3 commits into from
Sep 13, 2019

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Sep 11, 2019

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Unittests

  • What is the current behavior? (You can also link to an open issue here)

There are no unittests which verifies different get raw .. options

  • What is the new behavior (if this is a feature change)?

The following commands are checked
get raw ?
get raw is...
get raw MS;..

get raw file=
Option which opens a existing file doesn't work. This has to be done somehow later.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

  • Other information:

extended tests to improve coverage
@sidey79
Copy link
Contributor Author

sidey79 commented Sep 13, 2019

@HomeAutoUser

Kannst Du freigeben?

Copy link
Contributor

@HomeAutoUser HomeAutoUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dein Wunsch sei mir Befehl ;)

@sidey79 sidey79 merged commit f281cbc into dev-r34 Sep 13, 2019
@sidey79 sidey79 deleted the dev-r34_testGetRaw branch October 28, 2019 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants