Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct some logMethod calls #657

Merged
merged 5 commits into from
Sep 15, 2019
Merged

correct some logMethod calls #657

merged 5 commits into from
Sep 15, 2019

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Sep 15, 2019

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bugfix

  • What is the current behavior? (You can also link to an open issue here)

Serval direct SIGNALDuino_Log3 calls where missed with PR #644

  • What is the new behavior (if this is a feature change)?

The SIGNALDuino_Log3 calls are replaced with hash->{logMethod}->(

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

i don't think so

  • Other information:

sidey79 and others added 4 commits September 15, 2019 22:40
Fixed serveral SIGNALduino_Log3 calls. Changed them to hash->{logMethod}->(
Exit test with deactivated eventlogging
@sidey79 sidey79 changed the title 00_SIGNALduino.pm correct some logMethod calls Sep 15, 2019
HomeAutoUser
HomeAutoUser previously approved these changes Sep 15, 2019
updated
@coveralls
Copy link

coveralls commented Sep 15, 2019

Pull Request Test Coverage Report for Build 1773

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 1768: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

@sidey79 sidey79 merged commit d0fe760 into dev-r34 Sep 15, 2019
@sidey79 sidey79 deleted the dev-r34_fixlogging branch September 15, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants