Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update doc #658

Merged
merged 1 commit into from
Sep 15, 2019
Merged

Conversation

HomeAutoUser
Copy link
Contributor

@HomeAutoUser HomeAutoUser commented Sep 15, 2019

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • docs update
  • What is the current behavior? (You can also link to an open issue here)
  • no doc from this
  • What is the new behavior (if this is a feature change)?

- added doc from user RFD-FHEM#655
- revised doc in readme
@sidey79
Copy link
Contributor

sidey79 commented Sep 15, 2019

@HomeAutoUser
Copy link
Contributor Author

@HomeAutoUser
Copy link
Contributor Author

@sidey79, könntest du bitte die Quelle auf https://github.com/RFD-FHEM/SIGNALduino_TOOL/blob/dev_JSON_v2/FHEM/lib/SD_Device_ProtocolList.json umschwenken zugleich bzw. schauen ob deine Tests dort fehlerfrei ablaufen?

@sidey79
Copy link
Contributor

sidey79 commented Sep 15, 2019

Verstehe.

Die Tests laufen immer gegen den Branch dev_JSON_v1

Wenn das geändert werden soll, dann können wir das ändern:

https://github.com/HomeAutoUser/RFFHEM/blob/891dc056fc76d937d967404593cf595f0a267d02/UnitTest/tests/test_DeviceData_rmsg-definition.txt#L9

@HomeAutoUser HomeAutoUser merged commit 8b9d7c0 into RFD-FHEM:dev-r34 Sep 15, 2019
@HomeAutoUser HomeAutoUser deleted the dev-r34_doc_SD_BELL branch September 15, 2019 21:38
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1771

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 1768: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants