Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Test for SIGNALduino_CheckCmdResp #684

Merged
merged 2 commits into from
Nov 10, 2019
Merged

Added Test for SIGNALduino_CheckCmdResp #684

merged 2 commits into from
Nov 10, 2019

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Nov 10, 2019

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce?

UnitTest

  • What is the current behavior? (You can also link to an open issue here)

No UnitTest for this sub exists

  • What is the new behavior (if this is a feature change)?

Unittest verifys sub

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

no

  • Other information:

@sidey79 sidey79 changed the base branch from master to dev-r34 November 10, 2019 18:37
@sidey79 sidey79 force-pushed the dev-r34_testCheckCmdResp branch from 865dce3 to 2ab5296 Compare November 10, 2019 19:22
@coveralls
Copy link

coveralls commented Nov 10, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 1911

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 30.974%
Totals Coverage Status
Change from base Build 1906: 1.1%
Covered Lines: 3912
Relevant Lines: 12630
💛 - Coveralls

elektron-bbs
elektron-bbs approved these changes Nov 10, 2019
View reviewed changes
Copy link
Contributor

@elektron-bbs elektron-bbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich bestätige lediglich den Review ohne zu prüfen.

@sidey79 sidey79 merged commit 00c28d8 into dev-r34 Nov 10, 2019
@sidey79 sidey79 deleted the dev-r34_testCheckCmdResp branch November 10, 2019 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elektron-bbs elektron-bbs elektron-bbs approved these changes

@HomeAutoUser HomeAutoUser Awaiting requested review from HomeAutoUser

Assignees
No one assigned
Labels
unittest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sidey79 @coveralls @elektron-bbs