Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cc1101 detection #689

Merged
merged 4 commits into from
Nov 11, 2019
Merged

Fix cc1101 detection #689

merged 4 commits into from
Nov 11, 2019

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Nov 11, 2019

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

  • What is the current behavior? (You can also link to an open issue here)

Detection of cc1101 command was broken. Internal hasCC1101 was set to wrong value

  • What is the new behavior (if this is a feature change)?

Detection of cc1101 command is corrected.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

no

  • Other information:

Bug was introduced via: 4e7a90c

@sidey79 sidey79 added the bug label Nov 11, 2019
@sidey79 sidey79 marked this pull request as ready for review November 11, 2019 19:34
@sidey79 sidey79 requested a review from elektron-bbs November 11, 2019 19:35
@sidey79
Copy link
Contributor Author

sidey79 commented Nov 11, 2019

#688

@coveralls
Copy link

coveralls commented Nov 11, 2019

Pull Request Test Coverage Report for Build 1929

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 31.331%

Totals Coverage Status
Change from base Build 1913: 0.07%
Covered Lines: 3964
Relevant Lines: 12652

💛 - Coveralls

@sidey79 sidey79 merged commit 1a8242c into dev-r34 Nov 11, 2019
@sidey79 sidey79 deleted the dev-r34_fixCC1101Detection branch November 11, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants