Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev r34 fix tests #708

Merged
merged 2 commits into from
Dec 8, 2019
Merged

Dev r34 fix tests #708

merged 2 commits into from
Dec 8, 2019

Conversation

sidey79
Copy link
Contributor

@sidey79 sidey79 commented Dec 8, 2019

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Changes to support fhem 5.9 and report error correctly from bash

  • What is the current behavior? (You can also link to an open issue here)

bug in IsDummy is in fhem 5.9 still present, so i delete the attribute dummy in a test

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

no

  • Other information:

make test compatible with fhem 5.9
do not report anything is okay if there was an error in tests
@coveralls
Copy link

coveralls commented Dec 8, 2019

Pull Request Test Coverage Report for Build 2014

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 33.136%

Totals Coverage Status
Change from base Build 2011: 0.0%
Covered Lines: 4192
Relevant Lines: 12651

💛 - Coveralls

@sidey79 sidey79 merged commit 1f9dc55 into master Dec 8, 2019
@sidey79 sidey79 deleted the dev-r34_fixTests branch December 8, 2019 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants