added meta information to 00_SIGNALduino.pm #811

sidey79 · 2020-03-29T21:35:35Z

Please check if the PR fulfills these requirements

Tests for the changes have been added / modified (needed for for bug fixes / features)
commandref has been added / updated (needed for bug fixes / features)
CHANGED has been updated (needed for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:

coveralls · 2020-03-29T21:45:52Z

Pull Request Test Coverage Report for Build 2790

0 of 0 changed or added relevant lines in 0 files are covered.
5 unchanged lines in 5 files lost coverage.
Overall coverage remained the same at 54.021%

Files with Coverage Reduction	New Missed Lines	%
FHEM/00_SIGNALduino.pm	1	77.23%
FHEM/10_FS10.pm	1	6.15%
FHEM/14_SD_WS09.pm	1	69.5%
FHEM/14_SD_WS_Maverick.pm	1	6.43%
FHEM/41_OREGON.pm	1	1.75%

Totals
Change from base Build 2783:	0.0%
Covered Lines:	3305
Relevant Lines:	6118

💛 - Coveralls

coveralls · 2020-03-29T21:46:01Z

Pull Request Test Coverage Report for Build 2816

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 54.017%

Totals
Change from base Build 2797:	0.0%
Covered Lines:	3315
Relevant Lines:	6137

💛 - Coveralls

sidey79 · 2020-03-30T06:25:59Z

@HomeAutoUser

Du bist ja schnell.
Ich werde an den Informationen allerdings noch ein paar Korrekturen einpflegen.
Das war erst einmal der erste Wurf.

Mal sehen wie sich das dann auf Meldungen im FHEM Log auswirkt. :)

HomeAutoUser · 2020-03-30T08:54:06Z

@sidey79,
wenn ich in nächtlicher NixhtSchlummerPhase sein kann, so bin ich fix sobald da was mit Review steht 😂

Updated / corrected meta

Fixed json syntax

Fixed version number

sidey79 · 2020-04-01T06:42:53Z

@HomeAutoUser

So sieht das Ergebnis aktuell aus.
Mit der Angabe der Versionsnummer bin ich leider noch nicht zufrieden, weil da die commit Nummer vom SVN anhängt.

HomeAutoUser · 2020-04-01T08:25:16Z

Sieht auf jedenfall schonmal gut übersichtlich aus.

Die alias von @elektron-bbs und @HomeAutoUser musst Du nur noch tauschen 😉
Ich bin nicht er im alias und er ist nicht im alias ich grins

Kann man die Versionsnummer nicht „beschneiden“?

Updated meta information

sidey79 · 2020-04-01T21:52:18Z

@HomeAutoUser

Alias habe ich getauscht. Scheint wohl auf die Position anzukommen :)

Das Meta Modul generiert aus den im Modul angegeben Daten und was es sonst noch so auswertet ein JSON.

Und die Versionsnummer extrahiert es entweder aus dem Modul oder aus den hinterlegten Meta Daten.
Was genau im aktuellen hier verwendet wird, erschließt sich mir nicht.
Eigentlich sollte es das hinterlegt sein, aber es wird hier zumindest mit 0 aufgefüllt.

Die commit ID kommt dann später in der Anzeige dazu. Ich habe da keine Möglichkeiten gefunden, etwas zu ändern.


{
   "abstract" : "supports the same low-cost receiver for digital signals",
   "author" : [
      "Sidey <>",
      "homeautouser",
      "elektron-bbs",
      "ralf9"
   ],
   "description" : "This module interprets digitals signals provided from the signalduino hardware device and provides it to logical modules",
   "dynamic_config" : 1,
   "generated_by" : "FHEM::Meta v0.6.5, 2020-04-01 23:13:25",
   "keywords" : [
      "fhem-sonstige-systeme",
      "fhem-hausautomations-systeme",
      "signalduino",
      "fhem-mod",
      "fhem-core"
   ],
   "license" : [
      "GPL_2"
   ],
   "meta-spec" : {
      "url" : "https://metacpan.org/pod/CPAN::Meta::Spec",
      "version" : 2
   },
   "name" : "FHEM::SIGNALduino",
   "prereqs" : {
      "develop" : {
         "requires" : {
            "Data::Dumper" : "0",
            "IPC::Open3" : "0",
            "JSON" : "0",
            "Symbol" : "0",
            "Time::HiRes" : "0",
            "constant" : "0",
            "lib::SD_Protocols" : "0",
            "strict" : "0",
            "warnings" : "0"
         },
         "suggests" : {
            "Scalar::Util" : "0"
         }
      },
      "runtime" : {
         "recommends" : {
            "Data::Dumper" : "0"
         },
         "requires" : {
            "HttpUtils" : 0,
            "IPC::Open3" : "0",
            "JSON" : "0",
            "Symbol" : "0",
            "Time::HiRes" : "0",
            "constant" : "0",
            "lib::SD_Protocols" : "0",
            "perl" : 5.018,
            "strict" : "0",
            "warnings" : "0"
         },
         "suggests" : {
            "IO::Socket::SSL" : null,
            "Scalar::Util" : "0"
         },
         "x_inherited" : {
            "IO::Socket::SSL" : [
               "HttpUtils"
            ]
         }
      }
   },
   "release_status" : "testing",
   "resources" : {
      "bugtracker" : {
         "web" : "https://github.com/RFD-FHEM/RFFHEM/issues/"
      },
      "license" : [
         "https://fhem.de/#License"
      ],
      "repository" : {
         "type" : "svn",
         "url" : "https://svn.fhem.de/fhem",
         "web" : "https://svn.fhem.de/trac/browser/trunk/fhem/FHEM/00_SIGNALduino.pm",
         "x_branch" : "trunk",
         "x_dev" : {
            "type" : "git",
            "url" : "https://github.com/RFD-FHEM/RFFHEM.git",
            "web" : "https://github.com/RFD-FHEM/RFFHEM/tree/dev-r34",
            "x_branch" : "dev-r34",
            "x_filepath" : "FHEM/",
            "x_raw" : "https://raw.githubusercontent.com/RFD-FHEM/RFFHEM/master/FHEM/00_SIGNALduino.pm"
         },
         "x_filepath" : "fhem/FHEM/",
         "x_master" : {
            "type" : "git",
            "url" : "https://github.com/RFD-FHEM/RFFHEM.git",
            "web" : "https://github.com/RFD-FHEM/RFFHEM/tree/dev-r34"
         },
         "x_raw" : "https://svn.fhem.de/trac/export/latest/trunk/fhem/FHEM/00_SIGNALduino.pm"
      },
      "x_commandref" : {
         "web" : "https://commandref.fhem.de/#SIGNALduino"
      },
      "x_support_community" : {
         "board" : "Sonstige Systeme",
         "boardId" : "29",
         "cat" : "FHEM - Hausautomations-Systeme",
         "description" : "Sonstige Hausautomations-Systeme",
         "forum" : "FHEM Forum",
         "rss" : "https://forum.fhem.de/index.php?action=.xml;type=rss;board=29",
         "title" : "FHEM Forum: Sonstige Systeme",
         "web" : "https://forum.fhem.de/index.php/board,29.0.html"
      },
      "x_wiki" : {
         "web" : "https://wiki.fhem.de/wiki/SIGNALduino"
      }
   },
   "version" : "3.004002",
   "x_fhem_maintainer" : [
      "Sidey",
      "homeautouser",
      "elektron-bbs"
   ],
   "x_fhem_maintainer_github" : [
      "Sidey",
      "homeautouser",
      "elektron-bbs"
   ],
   "x_file" : [
      "FHEM/00_SIGNALduino.pm",
      "FHEM/",
      "00_SIGNALduino.pm",
      "00",
      "SIGNALduino",
      "pm",
      [
         2049,
         530190,
         33200,
         1,
         6061,
         6061,
         0,
         224594,
         [
            1553902629,
            "2019-03-30 00:37:09",
            "2019-03-30",
            "2019",
            "03",
            "30",
            "00:37:09",
            "00",
            "37",
            "09"
         ],
         [
            1585775562,
            "2020-04-01 23:12:42",
            "2020-04-01",
            "2020",
            "04",
            "01",
            "23:12:42",
            "23",
            "12",
            "42"
         ],
         [
            1585775562,
            "2020-04-01 23:12:42",
            "2020-04-01",
            "2020",
            "04",
            "01",
            "23:12:42",
            "23",
            "12",
            "42"
         ],
         4096,
         440
      ],
      "META.json",
      null
   ],
   "x_lang" : {
      "de" : {
         "abstract" : "Unterstuetzt den gleichnamigen Low-Cost Empfaenger fuer digitale Signale"
      }
   },
   "x_prereqs_src" : "META.json",
   "x_release_date" : "2019-12-29",
   "x_support_status" : "supported",
   "x_vcs" : [
      "$Id: 00_SIGNALduino.pm 20746 2019-12-29 12:30:52Z Sidey $",
      "00_SIGNALduino.pm",
      "00",
      "SIGNALduino",
      "pm",
      "20746",
      "2019-12-29 12:30:52",
      "2019-12-29",
      "2019",
      "12",
      "29",
      "12:30:52",
      "12",
      "30",
      "52",
      "Sidey",
      1577622652
   ],
   "x_version" : "00_SIGNALduino.pm:v3.4.2-s20746/2019-12-29 TESTING"
}

added meta information to module

075810a

HomeAutoUser marked this pull request as ready for review March 30, 2020 01:30

HomeAutoUser previously approved these changes Mar 30, 2020

View reviewed changes

00_SIGNALduino.pm

63f2cf0

Updated / corrected meta

sidey79 dismissed HomeAutoUser’s stale review via 63f2cf0 March 31, 2020 20:38

sidey79 force-pushed the dev-r34_meta branch 2 times, most recently from 4391e0c to 63f2cf0 Compare March 31, 2020 20:48

00_SIGNALduino.pm

f912a90

Fixed json syntax

sidey79 force-pushed the dev-r34_meta branch from 029f4d1 to f912a90 Compare March 31, 2020 21:17

00_SIGNALduino.pm

468b19c

Fixed version number

sidey79 force-pushed the dev-r34_meta branch from 9545d57 to 468b19c Compare March 31, 2020 21:53

00_SIGNALduino.pm

b3e81cd

Updated meta information

sidey79 force-pushed the dev-r34_meta branch from 89eb5f1 to b3e81cd Compare April 1, 2020 21:11

Automatic updated controls and CHANGED

4e3aa2c

sidey79 and others added 2 commits April 2, 2020 21:39

Merge branch 'dev-r34' into dev-r34_meta

bbcbea9

Automatic updated controls and CHANGED

7794693

HomeAutoUser approved these changes Apr 2, 2020

View reviewed changes

sidey79 merged commit eea8a54 into dev-r34 Apr 3, 2020

sidey79 deleted the dev-r34_meta branch April 3, 2020 19:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added meta information to 00_SIGNALduino.pm #811

added meta information to 00_SIGNALduino.pm #811

sidey79 commented Mar 29, 2020

coveralls commented Mar 29, 2020

coveralls commented Mar 29, 2020 •

edited

Loading

sidey79 commented Mar 30, 2020

HomeAutoUser commented Mar 30, 2020

sidey79 commented Apr 1, 2020

HomeAutoUser commented Apr 1, 2020

sidey79 commented Apr 1, 2020

added meta information to 00_SIGNALduino.pm #811

added meta information to 00_SIGNALduino.pm #811

Conversation

sidey79 commented Mar 29, 2020

coveralls commented Mar 29, 2020

Pull Request Test Coverage Report for Build 2790

💛 - Coveralls

coveralls commented Mar 29, 2020 • edited Loading

Pull Request Test Coverage Report for Build 2816

💛 - Coveralls

sidey79 commented Mar 30, 2020

HomeAutoUser commented Mar 30, 2020

sidey79 commented Apr 1, 2020

HomeAutoUser commented Apr 1, 2020

sidey79 commented Apr 1, 2020

coveralls commented Mar 29, 2020 •

edited

Loading