Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New protocol 97 Momento remote control for wireless digital picture frame #812

Merged
merged 2 commits into from
Mar 30, 2020

Conversation

elektron-bbs
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature

  • What is the current behavior? (You can also link to an open issue here)
    No decoding Momento remote control for wireless digital picture frame

  • What is the new behavior (if this is a feature change)?
    New protocol 97 Momento remote control for wireless digital picture frame

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

@coveralls
Copy link

coveralls commented Mar 30, 2020

Pull Request Test Coverage Report for Build 2795

  • 5 of 24 (20.83%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 53.756%

Changes Missing Coverage Covered Lines Changed/Added Lines %
FHEM/14_SD_UT.pm 4 23 17.39%
Totals Coverage Status
Change from base Build 2792: -0.3%
Covered Lines: 3285
Relevant Lines: 6111

💛 - Coveralls

@elektron-bbs
Copy link
Contributor Author

Du bist ja schneller als die Polizei erlaubt :-)
Ich hatte noch nicht mal die Testdaten im Signalduino-Tool. Kann man den Test eigentlich nochmal manuell in Githb anschubbsen?

@elektron-bbs elektron-bbs merged commit faadc74 into dev-r34 Mar 30, 2020
@HomeAutoUser
Copy link
Contributor

Es war ein günstiger Zeitpunkt. Ich nahm gerade das Tablett in die Hand :)
Die Tests kann man neu bzw re ausführen wenn man sich bei Travis mit Github einloggt.

@elektron-bbs
Copy link
Contributor Author

Aha, hab ich eben getan und war i.O.

@sidey79 sidey79 deleted the dev-r34_Momento branch April 3, 2020 19:59
@sidey79 sidey79 restored the dev-r34_Momento branch April 3, 2020 20:00
@elektron-bbs elektron-bbs deleted the dev-r34_Momento branch April 14, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants