Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new protocol for BBQ temperature sensor GT-TMBBQ-01 #894

Merged
merged 3 commits into from
Sep 30, 2020

Conversation

elektron-bbs
Copy link
Contributor

@elektron-bbs elektron-bbs commented Sep 27, 2020

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature

  • What is the current behavior? (You can also link to an open issue here)
    no decoding of protocol for BBQ temperature sensor GT-TMBBQ-01
    https://forum.fhem.de/index.php/topic,114437.0.html
    GT-TMBBQ-01e(Aldi/Globaltronics) Grillthermometer #892

  • What is the new behavior (if this is a feature change)?
    decoding of protocol for BBQ temperature sensor GT-TMBBQ-01

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

elektron-bbs and others added 2 commits September 27, 2020 16:45
SD_ProtocolData.pm: new: protocol 106 for BBQ temperature sensor GT-TMBBQ-01
14_SD_WS.pm: new: protocol 106 for BBQ temperature sensor GT-TMBBQ-01
@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #894 into master will increase coverage by 0.04%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #894      +/-   ##
==========================================
+ Coverage   54.21%   54.25%   +0.04%     
==========================================
  Files          60       60              
  Lines        7908     7916       +8     
  Branches     1271     1271              
==========================================
+ Hits         4287     4295       +8     
  Misses       2829     2829              
  Partials      792      792              
Flag Coverage Δ
#fhem 91.37% <ø> (ø)
#modules 91.37% <ø> (ø)
#perl 91.37% <ø> (ø)
#unittest 54.25% <80.00%> (+0.04%) ⬆️
#unittests 91.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/lib/SD_ProtocolData.pm 100.00% <ø> (ø)
FHEM/14_SD_WS.pm 52.05% <80.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9feb65b...a768f91. Read the comment docs.

@coveralls
Copy link

coveralls commented Sep 27, 2020

Pull Request Test Coverage Report for Build 3805

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 53.805%

Totals Coverage Status
Change from base Build 3802: 0.06%
Covered Lines: 3528
Relevant Lines: 6557

💛 - Coveralls

@sidey79
Copy link
Contributor

sidey79 commented Sep 27, 2020

@elektron-bbs

Wie könnten wir das jetzt mit den Testdaten im SIGNALduino_TOOL machen?

@HomeAutoUser
Copy link
Contributor

Ich klinke mich mal kurz ein.

Wie könnten wir das jetzt mit den Testdaten im SIGNALduino_TOOL machen?

Wie meinst du das genau @sidey79 ?

Die Testdaten wurden durch @elektron-bbs schon eingepflegt.
RFD-FHEM/SIGNALduino_TOOL@5c2630d

@sidey79
Copy link
Contributor

sidey79 commented Sep 30, 2020

@HomeAutoUser
Ich habe mal versucht mehr Rechte zu geben. Kannst Du jetzt mergen?

@HomeAutoUser HomeAutoUser merged commit 478a895 into master Sep 30, 2020
@HomeAutoUser
Copy link
Contributor

@sidey79 , ja es gelang und somit griffen die Zugriffsrechte.

@elektron-bbs elektron-bbs deleted the master_feature_GT-TMBBQ branch October 28, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants