Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some PerlCritic points - Update 14_SD_WS.pm #976

Merged
merged 2 commits into from
Jun 4, 2021

Conversation

HomeAutoUser
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • better clarity
  • What is the current behavior? (You can also link to an open issue here)
  • many hardTabs
  • What is the new behavior (if this is a feature change)?
  • revised hardTabs PerlCritic points & indentations
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

  • no function changes made to the code

HomeAutoUser and others added 2 commits June 3, 2021 21:46
 - revised hardTabs PerlCritic points & indentations
@HomeAutoUser HomeAutoUser added the Perl::Critic code revisions label Jun 3, 2021
@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #976 (5d16183) into master (b1d47ac) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #976   +/-   ##
=======================================
  Coverage   58.67%   58.67%           
=======================================
  Files         107      107           
  Lines        8585     8585           
  Branches     1339     1339           
=======================================
  Hits         5037     5037           
  Misses       2638     2638           
  Partials      910      910           
Flag Coverage Δ
fhem 48.68% <ø> (ø)
modules 58.67% <ø> (ø)
perl 91.57% <ø> (ø)
unittests 58.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
FHEM/14_SD_WS.pm 54.73% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1d47ac...5d16183. Read the comment docs.

@HomeAutoUser HomeAutoUser merged commit 6e9067f into RFD-FHEM:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Perl::Critic code revisions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants