-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bresser 5in1 2 - Rename readings windDirection, windDirectionText, windGust and windSpeed #995
Conversation
14_SD_WS.pm - Rename readings windDirection, windDirectionText, windGust and windSpeed SD_ProtocolData.pm - change register 0x03, Design Note DN009 - FIFOTHR.ADC_RETENTION - CC1101 will wake up with optimal ADC settings for low data rate (≤ 100 kbps)
Codecov Report
@@ Coverage Diff @@
## master #995 +/- ##
===========================================
- Coverage 91.57% 58.75% -32.83%
===========================================
Files 40 109 +69
Lines 2244 8636 +6392
Branches 138 1351 +1213
===========================================
+ Hits 2055 5074 +3019
- Misses 54 2638 +2584
- Partials 135 924 +789
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* revised test for right values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Der Branch muss noch aktualisiert werden :)
Hast du doch schon vorgenommen :-D |
Jetzt habe ich den Status Check irgendwie kaputt gemacht :( |
change reading windDirection in windDirectionDegree
Mhmm, beim letzten commit 1598646 liefen die Test noch fehlerfrei durch. |
Das liegt nicht an dir. |
OK, dann bin ich ja beruhigt :-) |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
other
What is the current behavior? (You can also link to an open issue here)
Protokoll für Bresser 5CH Temp Hygro #607 (comment)
What is the new behavior (if this is a feature change)?
Rename readings windDirection, windDirectionText, windGust and windSpeed.
Change register 0x03, Design Note DN009 - FIFOTHR.ADC_RETENTION - CC1101 will wake up with optimal ADC settings for low data rate (≤ 100 kbps).
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Other information: