Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCP-240313A: support future SPV proofs by refactoring anchors #228

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

dr-orlovsky
Copy link
Member

All non-consensus data has been removed from anchors and consignment API into resolver API, which can now return SPV info etc without consensus-breaking changes

Matches BP-WG/bp-core#84

@dr-orlovsky dr-orlovsky added refactoring Code refactoring *compatibility* Issues affecting compatibility and interoperability *consensus* Issues affecting distributed concensus labels Mar 30, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Mar 30, 2024
@dr-orlovsky dr-orlovsky requested review from nicbus and zoedberg March 30, 2024 12:26
All non-consensus data has been removed from anchors and consignment API into resolver API, which can now return SPV info etc without consensus-breaking changes
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 5.71429% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 14.1%. Comparing base (e04cfff) to head (2639236).

Files Patch % Lines
src/validation/validator.rs 0.0% 22 Missing ⚠️
src/validation/consignment.rs 0.0% 7 Missing ⚠️
src/bin/rgbcore-stl.rs 0.0% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #228   +/-   ##
======================================
  Coverage    14.1%   14.1%           
======================================
  Files          33      33           
  Lines        4154    4142   -12     
======================================
  Hits          585     585           
+ Misses       3569    3557   -12     
Flag Coverage Δ
rust 14.1% <5.7%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-orlovsky dr-orlovsky self-assigned this Apr 7, 2024
@dr-orlovsky dr-orlovsky merged commit 2639236 into master Apr 18, 2024
18 of 21 checks passed
@dr-orlovsky dr-orlovsky deleted the spv branch April 18, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*compatibility* Issues affecting compatibility and interoperability *consensus* Issues affecting distributed concensus refactoring Code refactoring
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant