Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #1

Merged
merged 3 commits into from
Apr 6, 2023
Merged

Update dependencies #1

merged 3 commits into from
Apr 6, 2023

Conversation

crisdut
Copy link
Member

@crisdut crisdut commented Mar 28, 2023

No description provided.

@crisdut crisdut marked this pull request as draft March 28, 2023 03:29
@dr-orlovsky
Copy link
Member

Thank you! Why WIP?

@crisdut
Copy link
Member Author

crisdut commented Mar 28, 2023

Thank you! Why WIP?

Hi, we need a new release of the rgb-core and rgb-wallet to finish the update of the rgbsc. I think we can wait a little longer to release these releases to give us time to test more. What do you think?

@dr-orlovsky
Copy link
Member

RGB Core/wallet were released previous night

@crisdut
Copy link
Member Author

crisdut commented Mar 29, 2023

RGB Core/wallet were released previous night

Yes, I know, and I started tests using these versions. I'm talking about releases of possible fixes and all that. I thought I'd go further into testing before we build a new version of these dependencies.

@crisdut
Copy link
Member Author

crisdut commented Mar 30, 2023

Hi @dr-orlovsky, I will turn this PR ready to review, after we merge and release new version contains a following PRs:

@dr-orlovsky dr-orlovsky marked this pull request as ready for review April 6, 2023 08:59
dr-orlovsky
dr-orlovsky approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This required more fixing, but to make it faster I just added them myself

examples/rgb20-simplest.rs Outdated
Comment on lines 181 to 182
for FungibleAllocation { owner, witness: _, value } in allocations {
eprintln!("(amount={value}, txout={owner})");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also print out witness txid info here.

BTW probably FungibleAllocation should be Display and this will also simplify things here

@dr-orlovsky dr-orlovsky merged commit 9e0d1b2 into RGB-WG:master Apr 6, 2023
@crisdut crisdut deleted the fix/update-example branch May 28, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-orlovsky dr-orlovsky dr-orlovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crisdut @dr-orlovsky