Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blank transition builder #127

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Fix blank transition builder #127

merged 1 commit into from
Jan 9, 2024

Conversation

crisdut
Copy link
Member

@crisdut crisdut commented Jan 7, 2024 •
edited
Loading

Alternative to #108

Close #81
Close #108

@dr-orlovsky
Copy link
Member

In #126 I moved from using dedicated *Allocation type and instead re-use types from RGB Core this way: https://github.com/RGB-WG/rgb-std/pull/126/files#diff-16373c59058401969ad1892e8d953d68a88387b2b435267816c230033c083201R83-R87

Can you please re-base this PR on top of that one to make them matching?

@crisdut crisdut changed the base branch from master to v0.11 January 9, 2024 12:53
dr-orlovsky
dr-orlovsky approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9e7b89d

@dr-orlovsky dr-orlovsky merged commit 3e1e417 into RGB-WG:v0.11 Jan 9, 2024
15 of 19 checks passed
@crisdut crisdut mentioned this pull request Jan 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-orlovsky dr-orlovsky dr-orlovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crisdut @dr-orlovsky