v0.11 fixes

[zoedberg]

This PR updates the tests to the v0.11 fixes epic.

It shows how this epic is fixing known open bugs in v0.11.

The epic includes the following fixes/changes:

• lint code with rust 1.84.0
• extend the tapret_wlt_receiving_opret test
• have contract commit to a single layer1
• have contract commit to a close method
• fix handling of RGB allocations on blinded UTXOs in case of a reorg (related issue: update_witnesses is not enough to handle reorgs rgb-std#296)
• fix undetected double spend (inflation) during accept transfer (related issue: bugs related to retrying an aborted transfer rgb-std#287)
• fix retrying the same blinded transfer (related issue: bugs related to retrying an aborted transfer rgb-std#287)
• add altered submodules to be able to write tests simulating an attacker using modified code
  • this needs to be amended once https://github.com/zoedberg/rgb/tree/revert_fix_same_blinded_transfer gets published on the RGB-WG rgb repo (@dr-orlovsky could you do it or give me the permission to push branches there?)

The epic is still missing:

• removal of pedersen commitments (will be done very similarly to Add new operators to avoid pedersen commitments in amount validation rgb-core#276 but it will completely drop the pedersen operators and avoid changing the INSTR_CONTRACT_TO constant)
• fix bp-wallet handling of reorgs (related issue: bitcoin reorgs are not handled BP-WG/bp-wallet#80) (still discussing the best approach in Handle re-orgs BP-WG/bp-wallet#81)
• fix/improve update_witnesses in the LN context (related issue: Calling update_witnesses in a lightning wallet may disrupt channel operations rgb-std#292)
• handle 429 esplora error (too many requests) on mainnet (related issue: error updating wallet caused by esplora rate limit  BP-WG/bp-wallet#70)
• once we are sure the "unified seals" proposal (RCP-250113A: Unify single-use seals RFC#16) works as expected we could apply it also on v0.11 and have the contract commit to an enum instead of a close method (e.g. TapretOnly, OpretOnly, 1stOpretThenTapret, 1stOpretOrTapret, etc)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.82%. Comparing base (d6c1603) to head (763cef8).

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   36.92%   36.82%   -0.11%     
==========================================
  Files         279      279              
  Lines       42804    42551     -253     
==========================================
- Hits        15805    15668     -137     
+ Misses      26999    26883     -116     

Flag	Coverage Δ
rust	36.82% <ø> (-0.11%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dr-orlovsky]

@zoedberg thank you

Can you please create a single tracking issue in rgb repo (like other tracking issues there) so it is easy to track the reviews and merging of all these many PRs?

[zoedberg]

Sure, done here RGB-WG/rgb#277.

@dr-orlovsky What about the branch I asked you to push? Could you please give me the permission to push branches on https://github.com/RGB-WG/rgb so that I do not bother you every time I have to update an altered branch?

[dr-orlovsky]

@zoedberg sorry I can't even recall this matter... Too much stuff..

Github permissions are weird and constantly change. I added Core Devs (a group where you in) as maintainers to rgb repo. Hope that helps.

[zoedberg]

Yep, that helped, thank you! Now the altered repo is not pointing to my fork anymore.