fix CRAN NOTE about files in temp directory #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
commented
Aug 21, 2021
| @@ -50,6 +50,7 @@ Invoke-WebRequest -Uri https://sourceforge.net/projects/qpdf/files/qpdf/10.3.1/q | |||
| Copy-Item .\qpdf -Destination $env:R_LIB_PATH -Recurse | |||
|
|
|||
| initexmf --set-config-value [MPM]AutoInstall=1 | |||
| $env:MIKTEX_EXCEPTION_PATH = "$env:TEMP\miktex" | |||
There was a problem hiding this comment.
This is to avoid the following new CRAN NOTE on Windows:
* checking for detritus in the temp directory ... NOTE
Found the following files/directories:
'lastMiKTeXException'
Env variable was found in sources of MikTeX:
https://github.com/MiKTeX/miktex/blob/ab8ebca7c70fe8c9a1392dfb2393a0a7683e14cc/Libraries/MiKTeX/Core/Exceptions.cpp#L155-L183
https://github.com/MiKTeX/miktex/blob/ab8ebca7c70fe8c9a1392dfb2393a0a7683e14cc/Libraries/MiKTeX/Core/include/miktex/Core/Environment.h#L37
We cannot remove MikTeX temp files during running testthat because PDF generation happens later in CRAN checks after tests have been finished.
Ideally, this path should be controlled via TempDir config value, but it doesn't.
https://mirror.truenetwork.ru/CTAN/systems/win32/miktex/doc/miktex.pdf
initexmf --set-config-value [Core]TempDir="$env:TEMP\miktex"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the following CRAN NOTE:
#348 (comment)