Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

es6 modules failing test #38

Merged
merged 2 commits into from
Feb 28, 2020
Merged

es6 modules failing test #38

merged 2 commits into from
Feb 28, 2020

Conversation

RGPosadas
Copy link
Owner

@RGPosadas RGPosadas requested a review from bit172 February 28, 2020 03:26
bit172
bit172 reviewed Feb 28, 2020
View reviewed changes
babel.config.js Outdated
return {
presets: ["babel-preset-expo"]
};
// module.exports = function(api) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the comments here

@RGPosadas RGPosadas force-pushed the BUG-1/es6-modules-failing-test branch from 1fba648 to c02599a Compare February 28, 2020 03:28
bit172
bit172 approved these changes Feb 28, 2020
View reviewed changes
Copy link
Collaborator

@bit172 bit172 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RGPosadas RGPosadas changed the title Bug 1/es6 modules failing test es6 modules failing test Feb 28, 2020
@RGPosadas RGPosadas merged commit b619687 into develop Feb 28, 2020
@cristian-aldea cristian-aldea deleted the BUG-1/es6-modules-failing-test branch February 28, 2020 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bit172 bit172 bit172 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RGPosadas @bit172 @ritchellesap