DNF5 support, python3-setuptools in rpmbuild-ctest, and pandas removal from rpmbuild-ctest
#241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--srpm option is not needed for dnf4 and not supported in dnf5.
than it solves. It enabled only testing of utils/create_srg_export.py script in Content
mildas
changed the title
python3-setuptools in rpmbuild-ctest, and pandas removal from rpmbuild-ctest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--srpmis not supported by dnf5 and dnf4 doesn't require it, thus to make it compatible with both, remove it.On Fedora Rawhide, I've hit there was missing
python3-setuptoolsrequired for Content build. Add it.Remove
pandasfrompip3in rpmbuild test. On Fedora it now requires python 3.10+. Previously, there were some compilation errors... Thus, rather remove it as it brings more problems than it solves - it added unit tests for SRG related util scripts which I don't consider that important.