build system: provide netif_ethernet implicitly

If there is an Ethernet peripheral (periph_eth feature provided), we can conclude that an Ethernet network interface can be provided. Co-authored-by: mguetschow <mikolai.guetschow@tu-dresden.de>
RIOT-OS · Jun 3, 2024 · 47f52bd · 47f52bd
1 parent 9187d16
commit 47f52bd
Show file tree

Hide file tree

Showing 8 changed files with 5 additions and 7 deletions.
diff --git a/Makefile.features b/Makefile.features
@@ -33,6 +33,10 @@ FEATURES_CONFLICT += periph_usbdev:tinyusb_host
 FEATURES_CONFLICT_MSG += "Package tinyUSB is not yet compatible with periph_usbdev."
 
 # Features provided implicitly
+ifneq (,$(filter periph_eth,$(FEATURES_PROVIDED)))
+  FEATURES_PROVIDED += netif_ethernet
+endif
+
 ifneq (,$(filter netif_%,$(FEATURES_PROVIDED)))
   FEATURES_PROVIDED += netif
 endif
diff --git a/boards/nucleo-f207zg/Makefile.features b/boards/nucleo-f207zg/Makefile.features
@@ -14,7 +14,6 @@ FEATURES_PROVIDED += periph_uart
 FEATURES_PROVIDED += periph_usbdev
 
 # Put other features for this board (in alphabetical order)
-FEATURES_PROVIDED += netif_ethernet
 FEATURES_PROVIDED += riotboot
 FEATURES_PROVIDED += tinyusb_device
 

diff --git a/boards/nucleo-f429zi/Makefile.features b/boards/nucleo-f429zi/Makefile.features
@@ -14,7 +14,6 @@ FEATURES_PROVIDED += periph_uart
 FEATURES_PROVIDED += periph_usbdev
 
 # Put other features for this board (in alphabetical order)
-FEATURES_PROVIDED += netif_ethernet
 FEATURES_PROVIDED += tinyusb_device
 
 # load the common Makefile.features for Nucleo boards

diff --git a/boards/nucleo-f439zi/Makefile.features b/boards/nucleo-f439zi/Makefile.features
@@ -13,7 +13,6 @@ FEATURES_PROVIDED += periph_uart
 FEATURES_PROVIDED += periph_usbdev
 
 # Put other features for this board (in alphabetical order)
-FEATURES_PROVIDED += netif_ethernet
 FEATURES_PROVIDED += tinyusb_device
 
 # load the common Makefile.features for Nucleo boards

diff --git a/boards/nucleo-f767zi/Makefile.features b/boards/nucleo-f767zi/Makefile.features
@@ -20,7 +20,6 @@ FEATURES_PROVIDED += periph_uart
 FEATURES_PROVIDED += periph_usbdev
 
 # Put other features for this board (in alphabetical order)
-FEATURES_PROVIDED += netif_ethernet
 FEATURES_PROVIDED += riotboot
 FEATURES_PROVIDED += tinyusb_device
 

diff --git a/boards/same54-xpro/Makefile.features b/boards/same54-xpro/Makefile.features
@@ -19,6 +19,5 @@ FEATURES_PROVIDED += periph_freqm
 FEATURES_PROVIDED += periph_can
 
 # Put other features for this board (in alphabetical order)
-FEATURES_PROVIDED += netif_ethernet
 FEATURES_PROVIDED += riotboot
 FEATURES_PROVIDED += tinyusb_device
diff --git a/boards/stm32f746g-disco/features-shared.mk b/boards/stm32f746g-disco/features-shared.mk
@@ -17,5 +17,4 @@ FEATURES_PROVIDED += periph_usbdev_hs
 FEATURES_PROVIDED += periph_usbdev_hs_ulpi
 
 # Put other features for this board (in alphabetical order)
-FEATURES_PROVIDED += netif_ethernet
 FEATURES_PROVIDED += tinyusb_device
diff --git a/dist/tools/buildsystem_sanity_check/check.sh b/dist/tools/buildsystem_sanity_check/check.sh
@@ -74,7 +74,7 @@ check_not_parsing_features() {
     # These two files contain sanity checks using FEATURES_ so are allowed
     pathspec+=(':!Makefile.include' ':!makefiles/info-global.inc.mk')
 
-    # We extend features provided in Makefile.features based on what is
+    # We extend FEATURES_PROVIDED in Makefile.features based on what is
     # already provided to avoid clutter in each boards Makefile.features.
     # E.g. `periph_eth` will pull in `netif_ethernet`, which
     # will pull in `netif`.