fixup! boards: add support for ESP32 ProS3 board

RIOT-OS · Feb 4, 2023 · 97373d8 · 97373d8
1 parent 9810617
commit 97373d8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/boards/esp32s3-pros3/Kconfig b/boards/esp32s3-pros3/Kconfig
@@ -22,6 +22,7 @@ config BOARD_ESP32S3_PROS3
     select HAS_PERIPH_SPI
     select HAS_PERIPH_USBDEV
     select HAS_TINYUSB_DEVICE
+    select MODULE_USB_BOARD_RESET if TEST_KCONFIG && MODULE_STDIO_USB_SERIAL_JTAG
 
 choice STDIO_IMPLEMENTATION
     bool "STDIO implementation"

diff --git a/boards/esp32s3-pros3/Makefile.dep b/boards/esp32s3-pros3/Makefile.dep
@@ -2,6 +2,10 @@ ifeq (,$(filter stdio_% slipdev_stdio usbus tinyusb_device,$(USEMODULE)))
   # Use stdio_usb_serial_jtag if no other stdio is requested explicitly
   # and neither USBUS nor tinyusb_device are used
   USEMODULE += stdio_usb_serial_jtag
+  # Even if only stdio_usb_serial_jtag is enabled, usb_board_reset is enabled
+  # since there should be a CDC ACM interface in any case. This is necessary,
+  # for example, to reset the board if stdio_cdc_acm or stdio_tinyusb_cdc_acm
+  # was previously used.
   USEMODULE += usb_board_reset
   include $(RIOTMAKE)/tools/usb_board_reset.mk
 endif