misc issues with tests/trickle #9052

ZetaR60 · 2018-04-30T19:31:53Z

Description

While running tests/trickle for #8904 on mega-xplained, I have run into a number of different issues. One issue is that prev_now is not being initialized properly in main (it assumes xtimer_now_usec is zero when main starts, which is not the case). This is easily fixed by adding prev_now = xtimer_now_usec(); to the beginning of main. There are also a number of problems where it hangs at various points.

Steps to reproduce the issue

Run tests/trickle with the following variations:

trunk on mega-xplained
cpu/atmega_common: return to non-interrupt context swaps #8904 applied to trunk on mega-xplained
trunk on mega-xplained with prev_now = xtimer_now_usec();
cpu/atmega_common: return to non-interrupt context swaps #8904 applied to trunk on mega-xplained with prev_now = xtimer_now_usec();

Expected results

tests/trickle runs, printing 5 messages after [START], and then 7 messages after [TRICKLE_RESET], and then prints [SUCCESS].

Actual results

Trunk hangs after [TRICKLE_RESET]
cpu/atmega_common: return to non-interrupt context swaps #8904 applied to trunk declares failure (due to not initializing prev_now properly)
Trunk with prev_now initialized hangs after three messages (I think this is a cpu/atmega_common: Context switching race condition #8896 related problem, and is fixed by cpu/atmega_common: return to non-interrupt context swaps #8904).
cpu/atmega_common: return to non-interrupt context swaps #8904 applied to trunk and prev_now initialized hangs after [TRICKLE_RESET]

Versions

Board: mega-xplained

Installed compiler toolchains 
-----------------------------
             native gcc: missing
      arm-none-eabi-gcc: missing
                avr-gcc: avr-gcc (Fedora 7.2.0-1.fc27) 7.2.0
       mips-mti-elf-gcc: missing
             msp430-gcc: missing
   riscv-none-embed-gcc: missing
                  clang: missing

Installed compiler libs
-----------------------
   arm-none-eabi-newlib: missing
    mips-mti-elf-newlib: missing
riscv-none-embed-newlib: missing
               avr-libc: "2.0.0" ("20150208")

Installed development tools
---------------------------
                  cmake: cmake version 3.11.0
               cppcheck: missing
                doxygen: missing
                 flake8: missing
                    git: git version 2.14.2
             coccinelle: missing

The text was updated successfully, but these errors were encountered:

cladmi · 2018-05-11T15:51:04Z

Thank for investigating this, I also had problem on tests/trickle with arduino-zero.
Adding the prev_now = xtimer_now_usec(); in main fixes it. I will do a PR for it.

Having `prev_now` initialized to 0 breaks tests on `arduino-zero` and `arduino-mega2560` as `xtimer_now_usec` is way bigger (72k on `arduino-zero`). Issue found in: * RIOT-OS#9052 and proposed fix by ZetaR60 * RIOT-OS/Release-Specs#62 (comment)

cladmi · 2018-05-11T16:02:37Z

I implemented your prev_now fix in #9118.

However I misread and thought it also fixed your problem, I can amend my commit message depending on your feedback.

ZetaR60 · 2018-05-11T17:23:40Z

@cladmi I found that prev_now = xtimer_now_usec(); improves the behavior of tests/trickle, but does not solve all of the problems (otherwise I would have just opened a PR). There is still the hang after [TRICKLE_RESET]. Do you get that hang on the platform you are testing (arduino-zero)? I took a look through the trickle code, but I am not sure what is causing it to hang.

Having `prev_now` initialized to 0 breaks tests on `arduino-zero` and `arduino-mega2560` as `xtimer_now_usec` is way bigger (72k on `arduino-zero`). Issue found in: * RIOT-OS#9052 and proposed fix by ZetaR60 * RIOT-OS/Release-Specs#62 (comment)

cladmi · 2018-05-15T13:06:23Z

@ZetaR60 I am not seeing any hang on arduino-zero in the trickle test, with the initialization fix, tests are working.
However I am not really using the board for anything, just running the automated tests on IoT-LAB.

ZetaR60 · 2018-05-15T18:44:09Z

@cladmi Below is what I get on mega-xplained. Could you post the output you are getting as well?

[liveuser@localhost-live trickle]$ make BOARD=mega-xplained test
tests/01-run.py
/home/liveuser/Desktop/RIOT_master/dist/tools/pyterm/pyterm -p "/dev/ttyACM0" -b "9600"
No handlers could be found for logger "root"
2018-05-15 14:33:52,852 - INFO # Connect to serial port /dev/ttyACM0
Welcome to pyterm!
Type '/exit' to exit.
2018-05-15 14:33:53,856 - INFO # 

2018-05-15 14:33:53,858 - INFO # random: NO SEED AVAILABLE!
2018-05-15 14:33:53,864 - INFO # main(): This is RIOT! (Version: 2018.07-devel-202-gd6c63-localhost-live)
2018-05-15 14:33:53,864 - INFO # [START]
2018-05-15 14:33:53,868 - INFO # now = 122792, prev_now = 75272, diff = 47520
2018-05-15 14:33:54,054 - INFO # now = 259928, prev_now = 122792, diff = 137136
2018-05-15 14:33:54,156 - INFO # now = 423144, prev_now = 259928, diff = 163216
2018-05-15 14:33:54,655 - INFO # now = 910360, prev_now = 423144, diff = 487216
2018-05-15 14:33:55,454 - INFO # now = 1640576, prev_now = 910360, diff = 730216
2018-05-15 14:33:55,456 - INFO # [TRICKLE_RESET]
Timeout in expect script at "child.expect(u"now = \d+, prev_now = \d+, diff = \d+")" (tests/trickle/tests/01-run.py:22)

make: *** [Makefile:10: test] Error 1
[liveuser@localhost-live trickle]$

Installed compiler toolchains 
-----------------------------
             native gcc: missing
      arm-none-eabi-gcc: missing
                avr-gcc: avr-gcc (Fedora 7.2.0-1.fc27) 7.2.0
       mips-mti-elf-gcc: missing
             msp430-gcc: missing
   riscv-none-embed-gcc: missing
                  clang: missing

Installed compiler libs
-----------------------
   arm-none-eabi-newlib: missing
    mips-mti-elf-newlib: missing
riscv-none-embed-newlib: missing
               avr-libc: "2.0.0" ("20150208")

Installed development tools
---------------------------
                  cmake: cmake version 3.11.0
               cppcheck: missing
                doxygen: missing
                 flake8: missing
                    git: git version 2.14.2
             coccinelle: missing

cladmi · 2018-05-16T12:18:52Z

I am running from my branch to run on IoT-LAB:

IOTLAB_NODE=auto-ssh make test BOARD=arduino-zero
tests/01-run.py
ssh -t harter@saclay.iot-lab.info 'socat - tcp:arduino-zero-1.saclay.iot-lab.info:20000'
main(): This is RIOT! (Version: 2018.07-devel-237-g2e252-inetm02-dev/rebase)
[START]
now = 91529, prev_now = 72464, diff = 19065
now = 129538, prev_now = 91529, diff = 38009
now = 204642, prev_now = 129538, diff = 75104
now = 378837, prev_now = 204642, diff = 174195
now = 624123, prev_now = 378837, diff = 245286
[TRICKLE_RESET]
now = 639444, prev_now = 624123, diff = 15321
now = 667641, prev_now = 639444, diff = 28197
now = 735840, prev_now = 667641, diff = 68199
now = 819041, prev_now = 735840, diff = 83201
now = 1129242, prev_now = 819041, diff = 310201
now = 1509621, prev_now = 1129242, diff = 380379
now = 2494089, prev_now = 1509621, diff = 984468
[SUCCESS]

Toolchain

Installed compiler toolchains 
-----------------------------
             native gcc: gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
      arm-none-eabi-gcc: arm-none-eabi-gcc (GNU Tools for Arm Embedded Processors 7-2017-q4-major) 7.2.1 20170904 (release) [ARM/embedded-7-branch revision 255204]
                avr-gcc: avr-gcc (GCC) 4.9.2
       mips-mti-elf-gcc: mips-mti-elf-gcc (Codescape GNU Tools 2016.05-03 for MIPS MTI Bare Metal) 4.9.2
             msp430-gcc: msp430-gcc (GCC) 4.6.3 20120301 (mspgcc LTS 20120406 unpatched)
   riscv-none-embed-gcc: missing
                  clang: clang version 3.8.0-2ubuntu4 (tags/RELEASE_380/final)

Installed compiler libs
-----------------------
   arm-none-eabi-newlib: "2.5.0"
    mips-mti-elf-newlib: "2.1.0"
riscv-none-embed-newlib: missing
               avr-libc: "1.8.0svn" ("20111229")

Installed development tools
---------------------------
                  cmake: cmake version 3.5.1
               cppcheck: Cppcheck 1.72
                doxygen: 1.8.11
                 flake8: 3.5.0 (mccabe: 0.6.1, pycodestyle: 2.3.1, pyflakes: 1.6.0) CPython 3.5.2 on Linux
                    git: git version 2.7.4
             coccinelle: spatch version 1.0.4 with Python support and with PCRE support

bergzand · 2018-05-16T12:24:39Z

@cladmi Correct me if I'm wrong, but the Arduino zero looks like a completely different architecture (32-Bit ARM Cortex M0+) than the Mega-Xplained (8-bit AVR RISC). Not sure if your test here is valid for trying to reproduce @ZetaR60 's issue

bergzand · 2018-05-16T12:52:37Z

The test correctly runs if I increase TR_IMIN to 40 (XTIMER_BACKOFF for the arduino).

bergzand · 2018-05-16T12:58:05Z

Not that those have anything to do with each other -_-

Having `prev_now` initialized to 0 breaks tests on `arduino-zero` and `arduino-mega2560` as `xtimer_now_usec` is way bigger (72k on `arduino-zero`). Issue found in: * RIOT-OS#9052 and proposed fix by ZetaR60 * RIOT-OS/Release-Specs#62 (comment)

cladmi · 2018-08-13T13:14:52Z

Note from the release tests, it is also broken on stm32discovery where the test detects the failure.

arduino-mega2560: stuck after TRICKLE_RESET
arduino-uno: stuck after TRICKLE_RESET
stm32discovery: test failure detected by firmware

ZetaR60 mentioned this issue Apr 30, 2018

cpu/atmega_common: return to non-interrupt context swaps #8904

Merged

kYc0o self-assigned this May 3, 2018

kYc0o added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Platform: AVR Platform: This PR/issue effects AVR-based platforms Area: timers Area: timer subsystems quality defect labels May 3, 2018

kYc0o added this to the Release 2018.07 milestone May 3, 2018

cladmi mentioned this issue May 11, 2018

tests/trickle: initialize prev_now in main #9118

Merged

cladmi modified the milestones: Release 2018.07, Release 2018.10 Aug 1, 2018

miri64 removed the quality defect label Oct 1, 2018

jia200x mentioned this issue Nov 2, 2018

tests/trickle: nondeterministic failure #10317

Closed

aabadie modified the milestones: Release 2018.10, Release 2019.01 Dec 2, 2018

aabadie removed this from the Release 2019.01 milestone Feb 12, 2019

aabadie added this to the Release 2019.04 milestone Feb 12, 2019

miri64 modified the milestones: Release 2019.04, Release 2019.07 May 7, 2019

MrKevinWeiss modified the milestones: Release 2019.07, Release 2019.10 Jul 25, 2019

miri64 added this to the Release 2020.07 milestone Jul 2, 2020

miri64 modified the milestones: Release 2020.07, Release 2020.10 Jul 24, 2020

MrKevinWeiss modified the milestones: Release 2020.10, Release 2021.07 Jun 22, 2021

MrKevinWeiss removed this from the Release 2021.07 milestone Jul 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

misc issues with tests/trickle #9052

misc issues with tests/trickle #9052

ZetaR60 commented Apr 30, 2018

cladmi commented May 11, 2018

cladmi commented May 11, 2018

ZetaR60 commented May 11, 2018

cladmi commented May 15, 2018

ZetaR60 commented May 15, 2018

cladmi commented May 16, 2018

bergzand commented May 16, 2018

bergzand commented May 16, 2018

bergzand commented May 16, 2018

cladmi commented Aug 13, 2018

misc issues with tests/trickle #9052

misc issues with tests/trickle #9052

Comments

ZetaR60 commented Apr 30, 2018

Description

Steps to reproduce the issue

Expected results

Actual results

Versions

cladmi commented May 11, 2018

cladmi commented May 11, 2018

ZetaR60 commented May 11, 2018

cladmi commented May 15, 2018

ZetaR60 commented May 15, 2018

cladmi commented May 16, 2018

bergzand commented May 16, 2018

bergzand commented May 16, 2018

bergzand commented May 16, 2018

cladmi commented Aug 13, 2018