Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/nucleo-l433rc: add I2C configuration #10647

Merged
merged 1 commit into from
Jan 2, 2019
Merged

boards/nucleo-l433rc: add I2C configuration #10647

merged 1 commit into from
Jan 2, 2019

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Dec 20, 2018

Contribution description

This PR configure one I2C peripheral for the nucleo-l433rc. I needed it for testing #10610 on L4 on this board and was too lazy for looking for an other one already configured.

Testing procedure

Build and flash any application that requires I2C, it should work. The I2C is configured to use SDA/SCL pins from the Arduino pinout.

Issues/PRs references

I needed it for testing #10610

@aabadie aabadie added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports labels Dec 20, 2018
@aabadie aabadie requested a review from MrKevinWeiss December 20, 2018 16:44
MrKevinWeiss
MrKevinWeiss reviewed Dec 20, 2018
View reviewed changes
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, nice. I checked the datasheet and it looks good (I think many are pb8 and pb9 but this one is pb7 and pb8).
I won't be able to to test it until I am back in the office, which won't be for a while. Maybe @leandrolanzieri can do a quick test.

I also trust you and am going to give it an untested ACK if @leandrolanzieri cannot test.

MrKevinWeiss
MrKevinWeiss approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears we cannot test. I am still confident everything is OK. I will give an untested ACK!

@tcschmidt
Copy link
Member

It appears we cannot test. I am still confident everything is OK. I will give an untested ACK!
@MrKevinWeiss can you assign labels according to the (partial) review you performed?

@MrKevinWeiss MrKevinWeiss added Platform: ARM Platform: This PR/issue effects ARM-based platforms Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Dec 24, 2018
@aabadie aabadie force-pushed the pr/boards/nucleo-l422rc-i2c branch from e1036d8 to 824201b Compare January 2, 2019 09:20
@aabadie
Copy link
Contributor Author

aabadie commented Jan 2, 2019

It appears we cannot test. I am still confident everything is OK

I could test my own PR and confirm it is still working after the rebase of this morning. Let's merge this. Thank you for reviewing @MrKevinWeiss !

@aabadie aabadie merged commit 0d6af64 into RIOT-OS:master Jan 2, 2019
@aabadie aabadie deleted the pr/boards/nucleo-l422rc-i2c branch January 2, 2019 10:03
@aabadie aabadie added this to the Release 2019.01 milestone Jan 4, 2019
@wosym wosym mentioned this pull request Jan 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrKevinWeiss MrKevinWeiss MrKevinWeiss approved these changes

Assignees
No one assigned
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Platform: ARM Platform: This PR/issue effects ARM-based platforms Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.01
Development

Successfully merging this pull request may close these issues.
3 participants
@aabadie @tcschmidt @MrKevinWeiss