Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc_ipv6_nib: activate SLAAC on border router #10824

Merged
merged 1 commit into from
Jan 24, 2019
Merged

gnrc_ipv6_nib: activate SLAAC on border router #10824

merged 1 commit into from
Jan 24, 2019

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jan 19, 2019

Contribution description

This fixes an issue of the addresses on the Ethernet interface of a border router never becoming valid.

Testing procedure

Flash a 6Lo-capable board (e.g. samr21-xpro) with gnrc_border_router. The Ethernet interface should now (check with ifconfig) have a valid address (signified by VAL instead of TNT[1]).

Issues/PRs references

Reported in #10817 (comment).

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 19, 2019
@miri64 miri64 added this to the Release 2019.01 milestone Jan 19, 2019
@miri64 miri64 mentioned this pull request Jan 19, 2019
Merged
gschorcht
gschorcht approved these changes Jan 19, 2019
View reviewed changes
Copy link
Contributor

@gschorcht gschorcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

gschorcht
gschorcht previously requested changes Jan 19, 2019
View reviewed changes
Copy link
Contributor

@gschorcht gschorcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it works with ESP32 border router, we should wait for a test with other boards

@miri64 miri64 dismissed gschorcht’s stale review January 19, 2019 10:34

Then rather not block but just dismiss your review ;-)

@cladmi
Copy link
Contributor

cladmi commented Jan 21, 2019

Not that I really understand/checked what make it works, but indeed the address is now VAL and not TNT[1] anymore.

I ran

BOARD=samr21-xpro make -C examples/gnrc_border_router/ flash term
...
# wait for uhcp saying some things
ifconfig

Output with this PR:

> ifconfig                                                                                                                                  
ifconfig                                                                                                                                    
Iface  6  HWaddr: 2F:FA  Channel: 26  Page: 0  NID: 0x23                                                                                    
          Long HWaddr: 79:76:75:5A:77:E7:2F:FA                                                                                              
           TX-Power: 0dBm  State: IDLE  max. Retrans.: 3  CSMA Retries: 4                                                                   
          AUTOACK  ACK_REQ  CSMA  MTU:1280  HL:64  RTR                                                                                      
          RTR_ADV  6LO  IPHC                                                                                                                
          Source address length: 8                                                                                                          
          Link type: wireless                                                                                                               
          inet6 addr: fe80::7b76:755a:77e7:2ffa  scope: local  VAL                                                                          
          inet6 addr: 2001:db8::7b76:755a:77e7:2ffa  scope: global  VAL                                                                     
          inet6 group: ff02::2
          inet6 group: ff02::1
          inet6 group: ff02::1:ffe7:2ffa

Iface  7  HWaddr: 02:35:E0:D9:FD:9C
          MTU:1500  HL:64  RTR
          RTR_ADV  Source address length: 6
          Link type: wired
          inet6 addr: fe80::35:e0ff:fed9:fd9c  scope: local  VAL
          inet6 addr: fe80::2  scope: local  VAL
          inet6 group: ff02::2
          inet6 group: ff02::1
          inet6 group: ff02::1:ffd9:fd9c
          inet6 group: ff02::1:ff00:2

output with master

ifconfig
Iface  6  HWaddr: 2F:FA  Channel: 26  Page: 0  NID: 0x23
          Long HWaddr: 79:76:75:5A:77:E7:2F:FA
           TX-Power: 0dBm  State: IDLE  max. Retrans.: 3  CSMA Retries: 4
          AUTOACK  ACK_REQ  CSMA  MTU:1280  HL:64  RTR
          RTR_ADV  6LO  IPHC
          Source address length: 8
          Link type: wireless
          inet6 addr: fe80::7b76:755a:77e7:2ffa  scope: local  VAL
          inet6 addr: 2001:db8::7b76:755a:77e7:2ffa  scope: global  VAL
          inet6 group: ff02::2
          inet6 group: ff02::1
          inet6 group: ff02::1:ffe7:2ffa

Iface  7  HWaddr: 02:35:E0:D9:FD:9C
          MTU:1500  HL:64  RTR
          RTR_ADV  Source address length: 6
          Link type: wired
          inet6 addr: fe80::35:e0ff:fed9:fd9c  scope: local  TNT[1]
          inet6 addr: fe80::2  scope: local  VAL
          inet6 group: ff02::2
          inet6 group: ff02::1
          inet6 group: ff02::1:ffd9:fd9c
          inet6 group: ff02::1:ff00:2

@cladmi cladmi added the Reviewed: 3-testing The PR was tested according to the maintainer guidelines label Jan 21, 2019
@miri64
Copy link
Member Author

miri64 commented Jan 24, 2019

@gschorcht is that enough for you to re-ACK?

gschorcht
gschorcht approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@gschorcht gschorcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@gschorcht gschorcht merged commit d90d546 into RIOT-OS:master Jan 24, 2019
@gschorcht
Copy link
Contributor

Thanks

@miri64
Copy link
Member Author

miri64 commented Jan 24, 2019

Thanks for the review! :-)

@miri64 miri64 deleted the gnrc_ipv6_nib/fix/br-slaac branch January 24, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gschorcht gschorcht gschorcht approved these changes

Assignees

@gschorcht gschorcht

Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 3-testing The PR was tested according to the maintainer guidelines Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2019.01
Development

Successfully merging this pull request may close these issues.
3 participants
@miri64 @cladmi @gschorcht